Skip to content

Validate minified adapter exports - #401

Open
Alek99 wants to merge 1 commit into
mainfrom
agent/fix-393-minified-adapter-exports
Open

Validate minified adapter exports#401
Alek99 wants to merge 1 commit into
mainfrom
agent/fix-393-minified-adapter-exports

Conversation

@Alek99

@Alek99 Alek99 commented Jul 31, 2026

Copy link
Copy Markdown
Member

What changed

  • Parse the production ESM export block instead of searching for unminified function declarations.
  • Accept both direct and aliased minifier output while still requiring ChartView, decodeFrame, and renderStandalone.

Why

The official Vite production build legitimately renames declarations. The old test asserted source spelling rather than the shipped public export contract, so it failed after a successful minified build.

Impact

The adapter asset test now follows the artifact users install and will still fail if any required public export disappears.

Validation

  • node js/build.mjs
  • .venv/bin/pytest -q tests/reflex_adapter/test_assets.py — 8 passed
  • .venv/bin/ruff check tests/reflex_adapter/test_assets.py

Fixes #393

Review in cubic

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Alek99, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 23045744-d8b4-4f25-9ef3-1a7a7fd126ec

📥 Commits

Reviewing files that changed from the base of the PR and between d505ef5 and 89fc44d.

📒 Files selected for processing (1)
  • tests/reflex_adapter/test_assets.py

Comment @coderabbitai help to get the list of available commands.

@codspeed-hq

codspeed-hq Bot commented Jul 31, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 109 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing agent/fix-393-minified-adapter-exports (89fc44d) with main (d505ef5)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Alek99
Alek99 marked this pull request as ready for review July 31, 2026 03:59

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[reflex-xy] asset test rejects the minified production JS bundle

1 participant