Fix computer properties for france - #1183
Closed
gabrielseco wants to merge 4 commits into
Closed
Conversation
The issue was that money fields were being converted to cents twice: 1. createHeadlessForm was calling convertToCents/parseFloat on money fields 2. The field transformations (transformValueToAPI) were calling convertToCents again This caused: - Input: 50000 EUR - First conversion: 5000000 cents (in createHeadlessForm) - Second conversion: 500000000 cents (in field transformations) - Schema computation: 500000000 * 0.05 = 25000000 cents - Display: 25000000 / 100 = 250000 EUR (wrong!) Fix: Remove money field processing from createHeadlessForm entirely. Let the field transformations handle the conversion as they should. Now: - Input: 50000 EUR - Field transformation: convertToCents(50000) = 5000000 cents - Schema computation: 5000000 * 0.05 = 250000 cents - Display: 250000 / 100 = 2500 EUR (correct!)
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (400 total)
✅ Bundle size check passed |
Contributor
📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.