Quote the previews flag, document PORT, and trim the comments - #10
Merged
Conversation
Two cleanups found running the template quality bar over the Render-specific commits. Neither changes what the live service does. render.yaml failed validation against render.com/schema/render.yaml.json: ['previews','generation'] -> False is not of type 'string' ['previews','generation'] -> False is not one of ['automatic','manual','off'] Bare `off` is a YAML boolean. Render's own parser reads it as the string anyway — the deployed service reports previews.generation "off" — so nothing was broken, but `render blueprints validate` and any schema-aware editor flag it, and a Blueprint that doesn't validate is a bad thing to hand someone as a starting point. Quoted, it validates with zero errors. PORT was the one env var declared in render.yaml and documented nowhere. Now that the Dockerfile's CMD passes it through to uvicorn it is a real knob, so both notes describe it as one: the README explains why it is declared at all rather than left to Render's port detection, and .env.example says what setting it does and doesn't do locally, since docker compose pins it to 8000 to keep the published ports and the healthchecks honest. Sits on top of the CMD fix, because a PORT documented as adjustable is only true with that change in. Verified: `render blueprints validate` reports valid: true with zero errors. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Every comment this fork added had grown into a paragraph. Cut them to the fact a reader can't get from the code, dropping restatements of the line below, detail already recorded elsewhere in the repo, and the history of how each fix was found. Comments only — no behavior, no config values. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits, no behavior change.
Quote the previews flag, and document PORT.
generation: offis a YAML boolean, so it failedrender blueprints validate. Quoted.PORTgained a README row and an.env.exampleentry — it's a real knob since #9, and nothing documented it.Trim the comments back to the reasons. Every comment this fork added had grown into a paragraph. Cut to what a reader can't get from the code. 14 files, 76 net lines gone.
Verified: blueprint valid, ruff clean, 27 unit tests pass,
docker buildsucceeds,shellcheckclean.README prose is untouched — that's an editorial pass, not a comment pass.
🤖 Generated with Claude Code