Release Prep v2.0.23#734
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Coverage Report for CI Build 27462694611Coverage decreased (-0.4%) to 99.468%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-templates the oauth2 gem using the kettle-jem template, refreshing generated project metadata, dependency floors, CI workflows, documentation output, and applying small internal refactors/cleanups alongside a version bump.
Changes:
- Bump gem version to
2.0.23and refresh changelog/docs outputs accordingly. - Refactor several spots to reduce duplicate method/option lookups (e.g., parser/options/headers) and improve lint/code-quality compliance (incl. Reek policy).
- Update development/tooling dependencies and CI workflow action pins; add stdlib-extracted gem coverage for
cgi/webrickin modular gemfiles.
Reviewed changes
Copilot reviewed 64 out of 70 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/oauth2/client_spec.rb | Avoid unused parameter warnings in a test helper class. |
| spec/oauth2/access_token_spec.rb | Reduce repeated target.params calls in assertions. |
| README.md | Metadata + badge/link refresh from templating. |
| Rakefile | Template timestamp refresh. |
| oauth2.gemspec | Update authors/emails and bump dependency floors. |
| LICENSE.md | Add copyright entry. |
| lib/oauth2/version.rb | Bump gem version to 2.0.23. |
| lib/oauth2/response.rb | Reduce duplicate lookups; minor parsing/header readability refactor. |
| lib/oauth2/error.rb | Reduce duplicate lookups in error parsing/message building. |
| lib/oauth2/client.rb | Refactor redirect counting, header sanitization helper, and reduce duplicate option lookups. |
| lib/oauth2/access_token.rb | Extract token-value logic into helper; small readability refactors in auth configuration. |
| gemfiles/modular/x_std_libs/vHEAD.gemfile | Include cgi/webrick extracted stdlib gems for HEAD. |
| gemfiles/modular/x_std_libs/r4/libs.gemfile | Include cgi/webrick extracted stdlib gems for Ruby 4.x. |
| gemfiles/modular/webrick/vHEAD.gemfile | Add webrick extracted stdlib gem constraint (HEAD). |
| gemfiles/modular/webrick/r4/v1.9.gemfile | Add webrick extracted stdlib gem constraint (Ruby 4.x). |
| gemfiles/modular/cgi/vHEAD.gemfile | Add cgi extracted stdlib gem constraint (HEAD). |
| gemfiles/modular/cgi/r4/v0.5.gemfile | Add cgi extracted stdlib gem constraint (Ruby 4.x). |
| gemfiles/modular/templating.gemfile | Bump kettle-drift floor. |
| gemfiles/modular/style.gemfile | Add rubocop-related gems used by the style toolchain. |
| gemfiles/modular/documentation.gemfile | Bump yard-fence floor. |
| gemfiles/modular/coverage.gemfile | Bump kettle-soup-cover floor. |
| Gemfile | Bump nomono floor. |
| Gemfile.lock | Lockfile refresh reflecting updated versions and added gems. |
| docs/OAuth2/Version.html | Regenerated YARD docs reflecting version bump. |
| docs/OAuth2/Response.html | Regenerated YARD docs reflecting refactors. |
| docs/OAuth2/Error.html | Regenerated YARD docs reflecting refactors. |
| docs/OAuth2/Client.html | Regenerated YARD docs reflecting refactors. |
| docs/OAuth2/AccessToken.html | Regenerated YARD docs reflecting refactors. |
| docs/index.html | Regenerated docs site index/README HTML output. |
| docs/file.README.html | Regenerated README HTML output. |
| docs/file.LICENSE.html | Regenerated LICENSE HTML output. |
| docs/file.CHANGELOG.html | Regenerated CHANGELOG HTML output. |
| CHANGELOG.md | Add 2.0.23 release entry; update advisory formatting and links. |
| bin/yri | Add Bundler-generated binstub. |
| bin/yardoc | Add Bundler-generated binstub. |
| bin/kettle-gha-sha-pins | Add Bundler-generated binstub. |
| bin/kettle-bump | Add Bundler-generated binstub. |
| .reek.yml | Introduce Reek policy/exclusions for compatibility constraints. |
| .kettle-drift.lock | Update drift lock line references after templating/regeneration. |
| .github/workflows/windows.yml | Update ruby/setup-ruby pin. |
| .github/workflows/unlocked_deps.yml | Update action pins (incl. tree-sitter + ruby setup). |
| .github/workflows/truffleruby-25.0.yml | Update ruby/setup-ruby pin. |
| .github/workflows/truffleruby-24.2.yml | Update ruby/setup-ruby pin. |
| .github/workflows/truffleruby-23.1.yml | Update ruby/setup-ruby pin. |
| .github/workflows/truffleruby-23.0.yml | Update ruby/setup-ruby pin. |
| .github/workflows/truffleruby-22.3.yml | Update ruby/setup-ruby pin. |
| .github/workflows/truffle.yml | Update ruby/setup-ruby pin. |
| .github/workflows/templating.yml | Update action pins (incl. tree-sitter + ruby setup). |
| .github/workflows/style.yml | Update ruby/setup-ruby pin; adjust RBS validation step. |
| .github/workflows/ruby-3.4.yml | Update ruby/setup-ruby pin. |
| .github/workflows/ruby-3.3.yml | Update ruby/setup-ruby pin. |
| .github/workflows/ruby-3.2.yml | Update ruby/setup-ruby pin. |
| .github/workflows/ruby-3.1.yml | Update ruby/setup-ruby pin. |
| .github/workflows/ruby-3.0.yml | Update ruby/setup-ruby pin. |
| .github/workflows/ruby-2.7.yml | Update ruby/setup-ruby pin. |
| .github/workflows/ruby-2.6.yml | Update ruby/setup-ruby pin. |
| .github/workflows/ruby-2.5.yml | Update ruby/setup-ruby pin. |
| .github/workflows/ruby-2.4.yml | Update ruby/setup-ruby pin. |
| .github/workflows/opencollective.yml | Update ruby/setup-ruby pin. |
| .github/workflows/macos.yml | Update ruby/setup-ruby pin. |
| .github/workflows/locked_deps.yml | Update ruby/setup-ruby pin. |
| .github/workflows/jruby.yml | Update ruby/setup-ruby pin. |
| .github/workflows/jruby-9.4.yml | Update ruby/setup-ruby pin. |
| .github/workflows/jruby-9.3.yml | Update ruby/setup-ruby pin. |
| .github/workflows/jruby-9.2.yml | Update ruby/setup-ruby pin. |
| .github/workflows/heads.yml | Update ruby/setup-ruby pin. |
| .github/workflows/dep-heads.yml | Update ruby/setup-ruby pin. |
| .github/workflows/current.yml | Update ruby/setup-ruby pin. |
| .github/workflows/coverage.yml | Update ruby/setup-ruby pin; adjust Coveralls action pin. |
| .github/workflows/auto-assign.yml | Update pozil/auto-assign-issue pin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix protocol-relative redirect component handling, keep REEK as a generated smell snapshot, restore RuboCop Gradual-clean formatting, and pin old TruffleRuby root appraisal json setup before appraisal install. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Avoid ruby/setup-ruby's bundle clean path on old TruffleRuby jobs and load set before multi_xml in the spec bootstrap. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use the generated Ruby 3.0 appraisal gemfile directly for TruffleRuby 22.3 and 23.0 to avoid Appraisal/Bundler crashes on those EOL runtimes. Keep the multi_xml 0.7 appraisal line below 0.8 for TruffleRuby parser compatibility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep experimental legacy Truffle runtime crashes from failing required CI and avoid asserting JSON parser wording that differs on TruffleRuby. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com