Skip to content

feat(combobox): reuse CheckboxGroup for required ComboboxCheckbox #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cirdes merged 2 commits into from
Jul 14, 2026
+61 −2
Merged

feat(combobox): reuse CheckboxGroup for required ComboboxCheckbox #479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d56238
feat(combobox): reuse CheckboxGroup for required ComboboxCheckbox
pierry01 Jul 14, 2026
0fec6f0
chore(mcp): rebuild registry.json for ComboboxCheckbox CheckboxGroup …
pierry01 Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions docs/app/views/docs/combobox.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,49 @@ def view_template
RUBY
end

render Docs::VisualCodeExample.new(title: "Required Checkbox", context: self) do
<<~RUBY
form(class: "flex flex-col gap-2 w-96") do
FormField do
FormFieldLabel { "Pick at least one" }

Combobox term: "things" do
ComboboxTrigger placeholder: "Pick value"

ComboboxPopover do
ComboboxSearchInput(placeholder: "Pick value or type anything")

ComboboxList do
ComboboxEmptyState { "No result" }

CheckboxGroup(data_required: true) do
ComboboxItem do
ComboboxCheckbox(name: "food[]", value: "apple", data: {value_missing: "Pick at least one option"})
span { "Apple" }
end

ComboboxItem do
ComboboxCheckbox(name: "food[]", value: "banana", data: {value_missing: "Pick at least one option"})
span { "Banana" }
end

ComboboxItem do
ComboboxCheckbox(name: "food[]", value: "carrot", data: {value_missing: "Pick at least one option"})
span { "Carrot" }
end
end
end
end
end

FormFieldError()
end

Button(type: "submit") { "Submit" }
end
RUBY
end

render Docs::VisualCodeExample.new(title: "Disabled", context: self) do
<<~RUBY
div(class: "w-96") do
Expand Down
9 changes: 8 additions & 1 deletion gem/lib/ruby_ui/combobox/combobox_checkbox.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,14 @@ def default_attrs
],
data: {
ruby_ui__combobox_target: "input",
action: "ruby-ui--combobox#inputChanged"
ruby_ui__checkbox_group_target: "checkbox",
ruby_ui__form_field_target: "input",
action: %w[
ruby-ui--combobox#inputChanged
change->ruby-ui--checkbox-group#onChange

@cubic-dev-ai cubic-dev-ai Bot Jul 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: After an invalid submit, selecting all options leaves the required-error message visible even though the combobox is now valid, because toggleAllItems() sets checked directly and never triggers these new change handlers. Dispatch a change for each updated input (or explicitly invoke the validation update) from the select-all path so the error state is refreshed with the selection.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At gem/lib/ruby_ui/combobox/combobox_checkbox.rb, line 26:

<comment>After an invalid submit, selecting all options leaves the required-error message visible even though the combobox is now valid, because `toggleAllItems()` sets `checked` directly and never triggers these new `change` handlers. Dispatch a change for each updated input (or explicitly invoke the validation update) from the select-all path so the error state is refreshed with the selection.</comment>

<file context>
@@ -19,7 +19,14 @@ def default_attrs
+          ruby_ui__form_field_target: "input",
+          action: %w[
+            ruby-ui--combobox#inputChanged
+            change->ruby-ui--checkbox-group#onChange
+            change->ruby-ui--form-field#onInput
+            invalid->ruby-ui--form-field#onInvalid
</file context>

@pierry01 pierry01 Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional and called out in the PR description under "Note on Select all".

It's cosmetic, not a functional issue: toggleAllItems() only produces a uniform state, so submission is always correct — all checked is valid (each checked option satisfies its own required) and all unchecked is correctly blocked. The only residue is that an already-visible FormFieldError message isn't refreshed by the select-all action itself; it clears on the next option interaction. We're leaving it as-is to keep this PR scoped to wiring ComboboxCheckbox to the existing CheckboxGroup controller (mirroring Checkbox), without touching the combobox controller.

change->ruby-ui--form-field#onInput
invalid->ruby-ui--form-field#onInvalid
]
}
}
end
Expand Down
9 changes: 9 additions & 0 deletions gem/test/ruby_ui/combobox_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,15 @@ def test_combobox_checkbox_renders_styled_input
assert_match(/checked:bg-primary/, output)
end

def test_combobox_checkbox_wires_checkbox_group_and_form_field
output = phlex { RubyUI.ComboboxCheckbox(name: "x", value: "1") }
assert_match(/data-ruby-ui--checkbox-group-target="checkbox"/, output)
assert_match(/data-ruby-ui--form-field-target="input"/, output)
assert_match(/change->ruby-ui--checkbox-group#onChange/, output)
assert_match(/change->ruby-ui--form-field#onInput/, output)
assert_match(/invalid->ruby-ui--form-field#onInvalid/, output)
end

def test_combobox_item_indicator_renders_check_svg
output = phlex { RubyUI.ComboboxItemIndicator() }
assert_match(/peer-checked:opacity-100/, output)
Expand Down
2 changes: 1 addition & 1 deletion mcp/data/registry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,7 +935,7 @@
},
{
"path": "combobox_checkbox.rb",
"content": "# frozen_string_literal: true\n\nmodule RubyUI\n class ComboboxCheckbox < Base\n def view_template\n input(type: \"checkbox\", **attrs)\n end\n\n private\n\n def default_attrs\n {\n class: [\n \"peer h-4 w-4 shrink-0 rounded-sm border border-primary ring-offset-background accent-primary\",\n \"disabled:cursor-not-allowed disabled:opacity-50\",\n \"checked:bg-primary checked:text-primary-foreground\",\n \"aria-disabled:cursor-not-allowed aria-disabled:opacity-50 aria-disabled:pointer-events-none\",\n \"focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2\"\n ],\n data: {\n ruby_ui__combobox_target: \"input\",\n action: \"ruby-ui--combobox#inputChanged\"\n }\n }\n end\n end\nend\n"
"content": "# frozen_string_literal: true\n\nmodule RubyUI\n class ComboboxCheckbox < Base\n def view_template\n input(type: \"checkbox\", **attrs)\n end\n\n private\n\n def default_attrs\n {\n class: [\n \"peer h-4 w-4 shrink-0 rounded-sm border border-primary ring-offset-background accent-primary\",\n \"disabled:cursor-not-allowed disabled:opacity-50\",\n \"checked:bg-primary checked:text-primary-foreground\",\n \"aria-disabled:cursor-not-allowed aria-disabled:opacity-50 aria-disabled:pointer-events-none\",\n \"focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2\"\n ],\n data: {\n ruby_ui__combobox_target: \"input\",\n ruby_ui__checkbox_group_target: \"checkbox\",\n ruby_ui__form_field_target: \"input\",\n action: %w[\n ruby-ui--combobox#inputChanged\n change->ruby-ui--checkbox-group#onChange\n change->ruby-ui--form-field#onInput\n invalid->ruby-ui--form-field#onInvalid\n ]\n }\n }\n end\n end\nend\n"
},
{
"path": "combobox_clear_button.rb",
Expand Down