[Improvement] Combobox: configurable popover placement#480
Merged
djalmaaraujo merged 3 commits intoJul 15, 2026
Conversation
Adds a `placement` value (default `bottom-start`, unchanged behavior) so consumers can position the popover differently, e.g. `left-start`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Jean Pierry <pierrybm@gmail.com>
cirdes
approved these changes
Jul 15, 2026
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
djalmaaraujo
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
No related issue — small enhancement.
Description
The combobox popover is currently pinned to
bottom-start(hardcoded incombobox_controller.js). This makes it awkward to embed a combobox where there's no room below the trigger — e.g. nested inside another popover/menu, or near the bottom of the viewport.This adds a
placementvalue to the Stimulus controller and a matchingplacement:argument to theComboboxcomponent, forwarded viadata-ruby-ui--combobox-placement-value. It's passed straight to Floating UI'scomputePosition, so any Floating UI placement works (bottom-start,left-start,top, etc.).Fully backward compatible: the default stays
bottom-start, so existing comboboxes render exactly as before.bottom-startbottom-start)