Fix multibyte non-alphanumeric chars for bare percent string literals#4131
Merged
Merged
Conversation
Alphanumerics are correctly handled in the check below by simply discarding the `%`. The same was not true for the other types, which caused some assumption to no longer hold.
Earlopain
force-pushed
the
bare-percent-multibyte-delimiter
branch
from
1360e4f to
286ba67
Compare
Earlopain
changed the title
Earlopain
changed the title
kddnewton
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4130
Alphanumerics are correctly handled in the check below by simply discarding the
%.The same was not true for the other types, which caused some assumption to no longer hold.