Fix colorization of imaginary/rational numbers#1733
Merged
Conversation
In prism there is no singualr `RATIONAL`/`IMAGINARY` token. Instead they are more fine-grained.
Earlopain
requested a deployment
to
fork-preview-protection
GitHub Actions
Waiting
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates RDoc::Parser::RubyColorizer to recognize rational/imaginary numeric literal variants (including combined forms) as :value tokens, and adds a regression test to ensure token text and classification are preserved.
Changes:
- Added coverage in
RubyColorizerfor integer/float imaginary, rational, and rational-imaginary token types. - Added a test validating correct colorization of
2i,2r,2ri, and float equivalents.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/rdoc/parser/ruby_colorizer_test.rb | Adds a regression test covering rational/imaginary numeric literal tokenization. |
| lib/rdoc/parser/ruby_colorizer.rb | Expands numeric token mapping to include combined rational/imaginary token types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
34
to
+43
| CONSTANT: :constant, | ||
| LABEL: :value, | ||
| INTEGER: :value, | ||
| INTEGER_IMAGINARY: :value, | ||
| INTEGER_RATIONAL: :value, | ||
| INTEGER_RATIONAL_IMAGINARY: :value, | ||
| FLOAT: :value, | ||
| RATIONAL: :value, | ||
| IMAGINARY: :value, | ||
| FLOAT_IMAGINARY: :value, | ||
| FLOAT_RATIONAL: :value, | ||
| FLOAT_RATIONAL_IMAGINARY: :value, |
Comment on lines
36
to
+43
| INTEGER: :value, | ||
| INTEGER_IMAGINARY: :value, | ||
| INTEGER_RATIONAL: :value, | ||
| INTEGER_RATIONAL_IMAGINARY: :value, | ||
| FLOAT: :value, | ||
| RATIONAL: :value, | ||
| IMAGINARY: :value, | ||
| FLOAT_IMAGINARY: :value, | ||
| FLOAT_RATIONAL: :value, | ||
| FLOAT_RATIONAL_IMAGINARY: :value, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In prism there is no singualr
RATIONAL/IMAGINARYtoken. Instead they are more fine-grained.