Fix incorrect method visibility when merging with existing store cache#1736
Open
4lllex wants to merge 1 commit into
Open
Fix incorrect method visibility when merging with existing store cache#17364lllex wants to merge 1 commit into
4lllex wants to merge 1 commit into
Conversation
Running Store#save with already existing cache incorrectly sets method visibility to `:private` on all methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
Store#savewith already existing cache incorrectly sets method visibility to:privateon all methods.@visibilitygets set during marshal_load:rdoc/lib/rdoc/code_object/class_module.rb
Lines 440 to 448 in bb8b2d4
and is reused during
merge->add_method:rdoc/lib/rdoc/code_object/class_module.rb
Lines 539 to 542 in bb8b2d4
rdoc/lib/rdoc/code_object/context.rb
Line 494 in bb8b2d4
Example:
Fixes #346