Form builder UI: new-form restyle, section field lists, editor polish#1639
Merged
Conversation
maebeale
force-pushed
the
maebeale/form-preview
branch
from
7d2e606 to
270c00f
Compare
maebeale
force-pushed
the
maebeale/form-builder-ui
branch
from
3170c5b to
615bddd
Compare
maebeale
force-pushed
the
maebeale/form-preview
branch
from
270c00f to
6e102bf
Compare
- Restyle the new-form page with the shared purple hero layout used by the questions and sections editors; change the editor eyebrow to "Edit". - Add a per-section expand toggle on the new-form and sections pages that lists the section's fields vertically. New forms use a hard-coded SECTION_FIELD_NAMES map (spec-guarded against builder drift); the sections editor lists the form's actual fields, falling back to the defaults. - Expanding a field's options tray tints the row and adds bottom padding. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The new-form restyle added content_for(:page_bg_class) to forms/new.html.erb, which the alignment guard requires to be enumerated in EXPECTED_MAPPINGS. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The professional_info builder now creates two fields (Primary service area + Additional service areas) where the constant still listed the old single Primary Service Area(s), failing the drift-guard spec on CI. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/form-builder-ui
branch
from
7ef8ef7 to
e5af54c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
How did you approach the change?
SECTION_FIELD_NAMESmap inFormBuilderService— guarded by a spec that builds every section and asserts the map matches, so it can't silently drift. The sections editor lists the form's actual fields, falling back to the defaults for not-yet-added sections.expandable-cardStimulus controller (no new toggle controller).UI Testing Checklist
Anything else to add?