Move fully to schemer - off-board deprecated kwalify

[simi]

• first commit -> I have ported 2 stricter checks to not lower the barrier
• second commit -> removed kwalify infrastructure

[simi]

@jasnow follow-up for #1067 (comment)

[simi]

@jasnow 🫡 happy to migrate also to https://github.com/jasnow/rkwalify if that's the preferred way forward now.

[simi]

Yup, I'll offboard the update to separate PR.

[jasnow]

I recommend making "rake" run both (with and without the kwalify code) for a while so we see if there are any differences. The "rake" will go from

• json and kwalify output to
• json and kwalify and non-kwalify output.

I will monitor the differences and report back to the team.

[jasnow]

I recommend making "rake" run both (with and without the kwalify code) for a while so we see if there are any differences. The "rake" will go from

• json and kwalify output to
• json and kwalify and non-kwalify output.

I will monitor the differences and report back to the team.

Alternative solution (2 runs: one with and one without)

• Uses an ENV[USEKWALIFY] variable to run kwalify-checks or not.
• **Unclear why it runs 3 times, only need 2. **
• Here is the results with move-to-schemer branch and changes in gist
  https://gist.github.com/jasnow/5b2fc2c126c1967a9a160f1e5404e25d
  • With USEKWALIFY="yes" rake
    • Finished in 1.63 seconds (files took 0.44612 seconds to load)
    • 1280 examples, 0 failures
    • Finished in 27.06 seconds (files took 14.91 seconds to load)
    • 59034 examples, 0 failures
    • Finished in 26.12 seconds (files took 11.6 seconds to load)
    • 57754 examples, 0 failures
  • unset USEKWALIFY ; rake
    • Finished in 2.11 seconds (files took 0.52456 seconds to load)
    • 1280 examples, 0 failures
    • Finished in 24.72 seconds (files took 12.3 seconds to load)
    • 57754 examples, 0 failures
    • Finished in 20.44 seconds (files took 14.62 seconds to load)
    • 56474 examples, 0 failures

[jasnow]

Took your PR changes plus the above "Alternative Solution" changes and created PR#1115.

[jasnow]

Created PR#1115 to use your changes plus USEKWALIFY changes.