Add -Zstack-protector-guard target modifier#159165
Open
alvinsun039 wants to merge 1 commit into
Open
Conversation
rustbot
added
A-LLVM
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @chenyukang (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
3 tasks
This comment has been minimized.
This comment has been minimized.
alvinsun039
force-pushed
the
stack-protector-guard-wip
branch
from
55ce98f to
f9353d7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Equivalent to Clang's `-mstack-protector-guard=*`. Allows configuring how the stack canary is accessed (global, TLS, or system register), which must be consistent across the crate graph.
alvinsun039
force-pushed
the
stack-protector-guard-wip
branch
from
f9353d7 to
d9c1148
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new unstable
-Z stack-protector-guardtarget modifier toconfigure how the stack canary is accessed, equivalent to Clang's
-mstack-protector-guard=*options.Usage:
-Z stack-protector-guard=<mode>[,offset=N][,reg=R][,symbol=S]This is needed by Rust-for-Linux to support per-task stack canary
(
CONFIG_STACKPROTECTOR_PER_TASK), where the canary is stored in aper-task location rather than a global
__stack_chk_guardvariable.MCP: rust-lang/compiler-team#1013
Zulip: https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/-Z.20stack-protector-guard.20flags