fix(test): test delete Windows registry accidently#4917
Closed
baka-gourd wants to merge 10 commits into
Closed
Conversation
…ove_from_path()` BREAKING CHANGE: Windows registry cleanup is no longer performed by `do_remove_from_path()`. Co-authored-by: baka-gourd <36119339+baka-gourd@users.noreply.github.com>
BREAKING CHANGE: `do_add_to_path()` will not add Windows registry
On Windows, fall back to `OpenMutexW` when `CreateMutexW` hits `ERROR_ACCESS_DENIED` for an existing registry guard mutex. This lets concurrent test processes wait on the shared mutex instead of failing during guard construction. Also update PATH registry tests for UUID-isolated roots, where the initial PATH may be absent and uninstall may correctly restore it to `None`. On Windows, fall back to `OpenMutexW` when `CreateMutexW` hits `ERROR_ACCESS_DENIED` for an existing registry guard mutex. This lets concurrent test processes wait on the shared mutex instead of failing during guard construction. Also update PATH registry tests for UUID-isolated roots, where the initial PATH may be absent and uninstall may correctly restore it to `None`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4915
This PR is intended to fix the issue mentioned in the ticket regarding the accidental deletion of existing registry entries. However, while investigating the problem, we also discovered a concurrency issue in RegistryGuard, so the scope of the fix is quite extensive.
Changes:
RegistryGuardto support multiple registry values and improve cleanup behavior.do_add_to_pathanddo_remove_from_pathonly modify PATH.do_add_to_programsanddo_remove_from_programsonly modify Programs entries.RegistryGuard::newAPI.No new UUID library has been introduced at this time; if needed,can use
uuid create.