Use manual bindings for WASIp2/3#830
Merged
Merged
Conversation
newpavlov
commented
Mar 12, 2026
newpavlov
force-pushed
the
wasi_manual_bindings
branch
from
490bd5e to
b8d55f6
Compare
briansmith
reviewed
Mar 16, 2026
Member
Author
|
@alexcrichton |
Collaborator
|
I'd say 3-6 months-ish would be my best guess |
Member
Author
flisky
reviewed
Jun 16, 2026
dhardy
approved these changes
Jun 17, 2026
dhardy
left a comment
dhardy
left a comment
Member
There was a problem hiding this comment.
I'm far from an expert in WASI, but from reading the discussions in #828/... I'm happy to stamp this as "approved".
IIUC from reading the discussion, link-time failure with contrived no-std examples is possible, but this will rarely be observed in practice; further, incorrect linking (due to the missing type information) should not happen.
@alexcrichton any further comments?
Member
Author
|
IIUC if we want to be absolutely sure that the linking problem can not happen we could use |
newpavlov
force-pushed
the
wasi_manual_bindings
branch
from
69b1d96 to
066825c
Compare
newpavlov
force-pushed
the
wasi_manual_bindings
branch
from
066825c to
0f439ca
Compare
Collaborator
|
No concerns/comments from me, I think this is reasonable to land 👍 |
Merged
eleboucher
pushed a commit
to eleboucher/towonel
that referenced
this pull request
Jun 18, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [getrandom](https://github.com/rust-random/getrandom) | workspace.dependencies | patch | `0.4.2` → `0.4.3` | --- ### Release Notes <details> <summary>rust-random/getrandom (getrandom)</summary> ### [`v0.4.3`](https://github.com/rust-random/getrandom/blob/HEAD/CHANGELOG.md#043---2026-06-17) [Compare Source](rust-random/getrandom@v0.4.2...v0.4.3) ##### Added - `wasm64-unknown-unknown` target support for `wasm_js` backend [#​848] ##### Changed - Drop `wasip2` and `wasip3` dependencies in favor of manual bindings [#​830] [0.4.3]: rust-random/getrandom@v0.4.2...v0.4.3 [#​830]: rust-random/getrandom#830 [#​848]: rust-random/getrandom#848 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL3BhdGNoIl19--> Reviewed-on: https://codeberg.org/towonel/towonel/pulls/31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #827