Skip to content

test(cli): cover recursive prefix download paths#252

Merged
overtrue merged 1 commit into
mainfrom
automation/test-gap-detection-20260705
Jul 4, 2026
Merged

test(cli): cover recursive prefix download paths#252
overtrue merged 1 commit into
mainfrom
automation/test-gap-detection-20260705

Conversation

@overtrue

@overtrue overtrue commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add one integration regression test for recursive S3 prefix downloads into a local directory.
  • Cover the recent download_prefix path branch so stripped keys like /dir/a.txt stay under the requested destination.

Evidence

  • Recent change bccd595 trimmed leading slashes in download_prefix after strip_prefix.
  • Existing recursive copy coverage checks S3-to-S3, but did not assert S3-to-local prefix download layout.

Validation

  • cargo test -p rustfs-cli --features integration --test integration test_recursive_download_prefix_keeps_paths_under_destination -- --nocapture
  • make pre-commit

Note: the focused integration test used the existing skip path on this machine because S3 test credentials are not configured.

@overtrue overtrue marked this pull request as ready for review July 4, 2026 21:25
Copilot AI review requested due to automatic review settings July 4, 2026 21:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@overtrue overtrue merged commit 5f94138 into main Jul 4, 2026
15 checks passed
@overtrue overtrue deleted the automation/test-gap-detection-20260705 branch July 4, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants