Update mypy to 1.20.0 - #559
Conversation
📝 WalkthroughWalkthroughThe development dependency Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/requirements_dev.txt (1)
1-3: Consider pinning all development dependencies for reproducibility.While the main change pins mypy to a specific version,
pytestandpylint2junitremain unpinned. This can lead to non-reproducible builds across different environments or over time. Consider pinning these dependencies as well to ensure consistent behavior.📌 Example: Pin all dependencies
You can generate a fully pinned requirements file using:
pip install pytest pylint2junit mypy==1.20.0 pip freeze | grep -E '^(pytest|pylint2junit|mypy)==' > src/requirements_dev.txtThis ensures all developers and CI environments use identical versions.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/requirements_dev.txt` around lines 1 - 3, The dev requirements file currently pins mypy but leaves pytest and pylint2junit unpinned; update src/requirements_dev.txt by pinning pytest and pylint2junit to specific versions (e.g., pytest==<version> and pylint2junit==<version>) so all three packages are fully pinned for reproducible builds—use pip freeze after installing the chosen versions to capture exact versions if needed.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/requirements_dev.txt`:
- Around line 1-3: The dev requirements file currently pins mypy but leaves
pytest and pylint2junit unpinned; update src/requirements_dev.txt by pinning
pytest and pylint2junit to specific versions (e.g., pytest==<version> and
pylint2junit==<version>) so all three packages are fully pinned for reproducible
builds—use pip freeze after installing the chosen versions to capture exact
versions if needed.
|
Closing this in favor of #564 |
1 participant
This PR updates mypy from 0.670 to 1.20.0.
Changelog
1.20
1.19.1
1.19
1.18.2
1.18.1