Debug and refactor artwork loading and hilt#48
Draft
scorp867 wants to merge 1 commit into
Draft
Conversation
Optimize artwork prefetching by deduplicating and batching requests. Integrate Hilt for dependency injection of LibraryRepository. Co-authored-by: justinbieber821721 <justinbieber821721@gmail.com>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize artwork prefetching and unify
LibraryRepositoryDI to reduce log spam and improve performance.The app was excessively prefetching artwork on every scroll event, even for tracks already known to have no embedded artwork, leading to a flood of debug logs and unnecessary processing. This PR addresses the issue by debouncing, filtering, and caching "no artwork" states, and by ensuring
LibraryRepositoryconsistently uses Hilt for proper dependency management.