QtFred fix volumetric related crash on mission load#7610
Merged
JohnAFernandez merged 1 commit intoJul 15, 2026
Conversation
JohnAFernandez
approved these changes
Jul 15, 2026
github-project-automation
Bot
moved this from Work In Progress (PRs)
to In Review (PRs)
in qtFRED2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FredRendererfreed its cached volumetric nebula hull model onmissionLoaded, by which pointclearMission()had already calledmodel_free_all()and the incoming mission's ships had reused the slot. Sincemodel_unload()reduces a model id to a slot index without checking the generation, this destroyed an unrelated ship's model and reset itsShip_info::model_numto -1, tripping "Invalid model number -1 requested" as soon as the mouse moved in the viewport.Fixed by freeing the volume model at the top of
clearMission(), while the model id is still valid, instead of after the new mission has loaded.