More Search UI/UX Enhancements#7612
Open
JohnAFernandez wants to merge 8 commits into
Open
Conversation
Items that begin with the search string should be prioritized before those that simply contain the search string.
I didn't see any crashes, but this matches the pattern of other keyboard shortcuts.
The working code existed already
This limits matches on operator searches by setting a minimum size that a string match has to meet. Function returns -1 on failure, and the warning has been removed to allow this behavior.
This allows ctrl+s (which can be listed instead of spacebar) to initiate search. There is a new menu item added as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has a few upgrades to the sexp search system, including:
Each feature was individually tested, and I'm open to feedback on adjustments.
Fixes #7604