fix(action_status_bridge): start with the default config#459
Open
mfaferek93 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a ROS 2 startup crash in ros2_medkit_action_status_bridge caused by shipping untyped empty YAML lists for parameters that are declared as std::vector<std::string> in the node. The change aligns the default config behavior with the node’s typed declared defaults so the bridge starts cleanly when launched with its packaged params file.
Changes:
- Remove untyped empty-list parameter assignments from
config/action_status_bridge.yamland replace them with commented, non-empty examples so ROS 2 uses the node’s typed defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of #458. Same empty-untyped-list crash as #444 (log_bridge), in
action_status_bridge- the #444 fix did not cover this package.config/action_status_bridge.yamlshipsexclude_actions: []andinclude_only_actions: []. Empty YAML lists are untyped, so launching the node with this file aborts at startup:The node code is correct (
declare_parameter<std::vector<std::string>>(...)); only the shipped YAML breaks it. This comments out the two lines with non-empty examples so the typed declared defaults apply.Verified live: with the shipped config the node aborts (exit 250); with this fix it starts clean (
ActionStatusBridge started ... Watching action ...).Addresses #458 (part 1). The log_bridge self-noise item in #458 is left as a follow-up: its fix touches
log_bridge.yaml, which #449 already modifies, so it is better done after #449 lands to avoid a conflict.