Harden Windows queue Planfile probes against non-UTF8 subprocess output#13
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix UnicodeDecodeError in Windows queue mode subprocess
Harden Windows queue Planfile probes against non-UTF8 subprocess output
Jul 18, 2026
Contributor
|
@copilot resolve the merge conflicts in this pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queue mode still crashed on Windows with
UnicodeDecodeErrorbecause some Planfile probe subprocesses were run in text mode, so Python reader threads decoded output as strict UTF-8 before Koru’s fallback logic could run. Ticket execution could complete, but probe paths still emitted background decode failures.Probe subprocess decoding moved to byte-safe path
src/koru/queue/ticket.py, switched probe calls fromsubprocess.run(..., text=True)totext=Falsein:_python_has_planfile_cli_planfile_supports_structured_queue_json_configured_planfile_cmd_usablekoru.queue.runners._decode_subprocess_output, aligning probe behavior with queue runner robustness.Version / marker parsing now operates on safely decoded text
Regression coverage for non-UTF8 probe output
tests/test_planfile_queue.pyfor: