[UIK-5351][theme] Add more variables to theme#3039
Open
j-mnizhek wants to merge 18 commits into
Open
Conversation
github-actions
Bot
added
badge
feature-highlight
base-components
base-trigger
select
time-picker
add-filter
date-picker
button
wizard
side-panel
pagination
notice-bubble
feedback-form
modal
fullscreen-modal
carousel
notice
inline-input
feature-popover
errors
dropdown-menu
data-table
color-picker
card
drag-and-drop
bulk-textarea
labels
j-mnizhek
requested review from
Valeria-Zimnitskaya,
ilyabrower and
slizhevskyv-semrush
ilyabrower
reviewed
Jul 3, 2026
ilyabrower
reviewed
Jul 3, 2026
Contributor
|
@j-mnizhek @ilyabrower i found a bug here Here how it looks now: |
Member
Author
I fixed this, the reason: I was experimenting with moving some old variables to the control group (as Ilia proposed) and forgot to mark it as deprecated |
…elements (#3045) ## Changelog ### @semcore/dropdown-menu #### Fixed - `preventFocusByClick` handler - skip draggable elements. <!--- Provide a general summary of your changes in the Title above --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## How has this been tested? <!--- Please describe in detail how you tested your changes. --> <!--- For example: --> <!--- I have added unit tests --> <!--- I have added Voice Over tests --> <!--- Code cannot be tested automatically so I have tested it only manually --> ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [X] Bug fix (non-breaking change which fixes an issue). - [ ] New feature (non-breaking change which adds functionality). - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected). - [ ] Nice improve. ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have updated the documentation accordingly. - [ ] I have added new tests on added of fixed functionality.
ilyabrower
reviewed
Jul 10, 2026
ilyabrower
left a comment
ilyabrower
left a comment
Contributor
There was a problem hiding this comment.
It looks like the tokens are sorted alphabetically, but previously they were sorted by meaning. Were these changes necessary?
Member
Author
Yep, it's necessary for now, alphabetical order is temporary, just for convenience during the updating styles |
Contributor
|
@ilyabrower @j-mnizhek after merge release/v17 i see that new wizard styled not applied Actual: Expected: should be black |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
@semcore/theme
Added
Motivation and Context
How has this been tested?
Manually.
Types of changes
Checklist: