[UIK-5567][carousel] rewrite component to NS#3052
Open
slizhevskyv-semrush wants to merge 1 commit into
Open
Conversation
| active?: boolean; | ||
| onClick?: () => void; | ||
| inverted?: boolean; | ||
| } & CarouselItem; |
Contributor
Author
There was a problem hiding this comment.
note:
I've removed CarouselItem since it's not used within Indicator component. Let me know whether it's needed. Thanks!
Contributor
There was a problem hiding this comment.
indicators could be like mini items... maybe because of that it was like that... check please this example https://developer.semrush.com/intergalactic/components/carousel/carousel-code#carousel-with-preview-indicators
Contributor
Author
There was a problem hiding this comment.
node prop means nothing for Indicator. The component doesn't handle it :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
@semcore/carousel
Fixed
NSCarouselnamespace.Motivation and Context
Refactor component types. Deprecated atomic types in favor namespaces. Nothing changed in how component works.
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: