Skip to content

[UIK-5566][button] rewrite component to NS#3053

Open
slizhevskyv-semrush wants to merge 1 commit into
release/v17from
UIK-5566/rewrite-component-to-ns
Open

[UIK-5566][button] rewrite component to NS#3053
slizhevskyv-semrush wants to merge 1 commit into
release/v17from
UIK-5566/rewrite-component-to-ns

Conversation

@slizhevskyv-semrush

Copy link
Copy Markdown
Contributor

Changelog

@semcore/button

Changed

  • Refactor component types. Deprecated atomic types. Atomic types are part of NSButton/NSButtonLink namespaces.

Motivation and Context

Refactor component types. Deprecated atomic types in favor namespaces. Nothing changed in how component works.

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

{loading && (
<SSpin tag='span'>
<SpinButton centered size={size} theme={useTheme} />
<Spin

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilyabrower

note:
Decided to eliminate SpinButton component with weak types since it's not exported outside and only used within Button component. Updated mapping to reflect latest values for size, etc.
Let me know if there is smth I have to fix :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant