[UIK-5566][button] rewrite component to NS#3053
Open
slizhevskyv-semrush wants to merge 1 commit into
Open
Conversation
| {loading && ( | ||
| <SSpin tag='span'> | ||
| <SpinButton centered size={size} theme={useTheme} /> | ||
| <Spin |
Contributor
Author
There was a problem hiding this comment.
note:
Decided to eliminate SpinButton component with weak types since it's not exported outside and only used within Button component. Updated mapping to reflect latest values for size, etc.
Let me know if there is smth I have to fix :)
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
@semcore/button
Changed
NSButton/NSButtonLinknamespaces.Motivation and Context
Refactor component types. Deprecated atomic types in favor namespaces. Nothing changed in how component works.
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: