refactor/soap-ssl-validator-openssl#414
Open
ioigoume wants to merge 1 commit into
Open
Conversation
…penSSL-based key extraction and updating tests
ioigoume
force-pushed
the
refactor/soap-ssl-validator-openssl
branch
from
c0f7417 to
8470675
Compare
Member
|
Thank you so much @ioigoume ! |
tvdijen
reviewed
Jul 2, 2026
| } | ||
|
|
||
| $alg = $artifactResponse->getSignature()->getSignedInfo()->getSignatureMethod()->getAlgorithm(); | ||
| $signatureMethod = $alg instanceof AnyURIValue ? $alg->getValue() : (string) $alg; |
Member
There was a problem hiding this comment.
What is the idea here? Isn't the algorithm always one of AnyURIValue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove xmlseclibs coupling by switching SOAP/Artifact validators to OpenSSL-based key extraction and updating tests