feat: remove guard from "external-auth add-secret" command for non-hosted apps#586
Conversation
The external-auth add-secret command no longer requires apps to be deployed to Slack managed infrastructure. Any app in a valid project directory can now use this command without the --force flag.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
==========================================
- Coverage 71.68% 71.63% -0.05%
==========================================
Files 226 226
Lines 19184 19176 -8
==========================================
- Hits 13752 13737 -15
- Misses 4221 4224 +3
- Partials 1211 1215 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zimeg
changed the title
zimeg
added
enhancement
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Absolutely love this PR! It's continuing to expand the CLI beyond ROSI.
🖊️ You asked whether this is meaningful to ungate. I think it is. Platform hasn't actively prevented external auth from non-ROSI apps and continues to invest into that surface. We should feel comfortable enabling more developers to use it.
| // preRunAddClientSecretCommand determines if the command is supported for a | ||
| // project and configures flags | ||
| func preRunAddClientSecretCommand(ctx context.Context, clients *shared.ClientFactory, cmd *cobra.Command) error { | ||
| // preRunAddClientSecretCommand configures flags and validates the project directory |
There was a problem hiding this comment.
praise: Renaming the doc comment from "determines if the command is supported for a project" to "configures flags and validates the project directory" matches what the function actually does post-ungate. Tight follow-through. 🤾🏻 💥
|
@mwbrooks Praises back to the kind review 🎁 I'll keep this PR scoped to this command but will keep watch for when other |
2 participants
Changelog
The
external-auth add-secretcommand is now available to all apps instead of just apps run on Slack-managed infrastructure.Summary
This PR removes the ROSI guards from the
external-auth add-secretcommand to unlock this option for configuring external auth providers outside of WFB.Testing
Follow these setup steps without using the "--force" flag:
🔗 https://github.com/slack-samples/bolt-js-examples/tree/feat/mcp-client-examples/ai/mcp-client/external-auth
Notes
external-selectcommands are meaningful to ungate or if we should wait for feedback on a use case? Open to follow up however!Requirements