Replace deprecated PYBIND11_OVERLOAD* by PYBIND11_OVERRIDE*#618
Replace deprecated PYBIND11_OVERLOAD* by PYBIND11_OVERRIDE*#618alxbilger wants to merge 1 commit into
Conversation
fredroy
left a comment
There was a problem hiding this comment.
This is effectively increase the minimum required version of pybind for SofaPython3 to 2.6 (https://pybind11.readthedocs.io/en/stable/changelog.html#v2-6-0-oct-21-2020), as pybind11 introduced this PYBIND11_OVERRIDE macro in this version ; whereas in the cmakefile of SofaPython3 :
Line 120 in e6fb484
I am not necessarily against the change (v2.6 is 6 years old now...), but it has to be noticed
|
You're right. I did not think about looking at the minimum required version. The macros |
See https://pybind11.readthedocs.io/en/stable/upgrade.html#v2-6