fix: unptr datatype in errors - #2767
Merged
Merged
Conversation
|
pkg.pr.new packages benchmark commit |
Resolution Time Benchmark---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Random Branching (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.94, 1.97, 3.92, 6.43, 7.58, 13.33, 22.14, 22.95]
line [0.98, 2.02, 4.23, 7.11, 7.31, 12.46, 22.63, 25.61]
line [0.94, 1.97, 4.18, 6.56, 8.28, 11.28, 21.82, 22.08]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Linear Recursion (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.29, 0.51, 0.76, 0.85, 1.14, 1.20, 1.46, 1.57]
line [0.34, 0.58, 0.73, 0.83, 1.20, 1.19, 1.45, 1.60]
line [0.31, 0.52, 0.69, 0.83, 1.08, 1.17, 1.43, 1.59]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Full Tree (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.89, 2.09, 4.06, 7.53, 13.85, 26.38, 55.83, 114.50]
line [1.02, 2.56, 4.75, 7.20, 13.42, 26.13, 55.73, 113.47]
line [0.84, 2.09, 4.06, 6.58, 13.00, 26.57, 56.31, 112.12]
|
Bundle size comparison (
|
| 🟢 Decreased | ➖ Unchanged | 🔴 Increased (max 0.00%) | ❔ Unknown |
|---|---|---|---|
| 0 | 301 | 21 | 0 |
import { ... } in PR vs import * as ... in PR (is the library tree-Shakeable?):
| Test | tsdown |
|---|---|
| tgpu_init.ts | 258.90 kB ( |
| tgpu_initFromDevice.ts | 258.39 kB ( |
| tgpu_resolve.ts | 164.60 kB ( |
| tgpu_resolveWithContext.ts | 164.53 kB ( |
| tgpu_bindGroupLayout.ts | 68.97 kB ( |
| tgpu_mutableAccessor.ts | 65.97 kB ( |
| tgpu_accessor.ts | 65.96 kB ( |
| tgpu_privateVar.ts | 65.31 kB ( |
| tgpu_workgroupVar.ts | 65.30 kB ( |
| tgpu_const.ts | 64.55 kB ( |
| tgpu_fn.ts | 38.14 kB ( |
| tgpu_fragmentFn.ts | 38.14 kB ( |
| tgpu_vertexFn.ts | 37.96 kB ( |
| tgpu_computeFn.ts | 37.66 kB ( |
| tgpu_vertexLayout.ts | 26.79 kB ( |
| tgpu_comptime.ts | 14.48 kB ( |
| tgpu_unroll.ts | 1.66 kB ( |
| tgpu_slot.ts | 1.54 kB ( |
| tgpu_lazy.ts | 1.19 kB ( |
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu.
Contributor
There was a problem hiding this comment.
Reviewed changes — a one-line fix to display the inner datatype (e.g. vec3f) rather than the pointer type (ptr<function, vec3f, read-write>) in the reference-assignment error message, plus tests covering both implicit and explicit pointer scenarios.
- Fix
unptrin error message — wrapsrhsExpr.dataTypewithunptr()before resolving for display, matching the pattern already used at four other error/stringification sites in the same file. - Add two test cases — verifies that implicit pointer (variable alias) and explicit pointer (
d.ref()) assignments both produce error messages with the unwrapped type in the suggested fix snippet.
✅ No new issues found.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) | 𝕏
iwoplaza
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.