WPF sample: fix blank chart on non-English locales and related bugs#34
Open
toolsche wants to merge 1 commit into
Open
WPF sample: fix blank chart on non-English locales and related bugs#34toolsche wants to merge 1 commit into
toolsche wants to merge 1 commit into
Conversation
- Chart.cs: format OHLC values with InvariantCulture. They were interpolated with the current culture, so on cultures using ',' as the decimal separator (e.g. German) createChart received invalid JavaScript and the chart stayed blank. - WPF.Sample.csproj: add CopyToOutputDirectory for hammer.js and chartjs-plugin-zoom.min.js. They are referenced by chart.html but only had CopyToPublishDirectory, so they were missing from a normal build output. - ChartingService.cs: load chart.html via a proper file:// URI resolved from the app directory (AppContext.BaseDirectory) instead of Environment.CurrentDirectory plus a raw Windows path. - ShellViewModel.cs: de-duplicate conversion-symbol requests on account change. Each distinct quote asset is now requested once instead of once per symbol, cutting hundreds of sequential round-trips and bringing account load from minutes to seconds. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few bug fixes for the WPF sample (
Trading.UI.Sample).Blank chart on non-English locales
Chart.csbuilt thecreateChart(...)JavaScript by interpolatingdoubleOHLC values with the current culture. On cultures that use,as the decimal separator (e.g. German) this produced invalid JS likeo: 1,2345, throwingUncaught SyntaxError: Unexpected token ',', socreateChartnever ran and the chart stayed blank. Values are now formatted withInvariantCulture.Missing chart assets in build output
hammer.jsandchartjs-plugin-zoom.min.jsare referenced bychart.htmlbut were declared with onlyCopyToPublishDirectory, so a normaldotnet builddid not copy them to the output directory. AddedCopyToOutputDirectory.Robust chart.html loading
ChartingServiceloadedchart.htmlfromEnvironment.CurrentDirectorywith a raw Windows path. It now resolves the path from the app directory (AppContext.BaseDirectory) and hands CefSharp a properfile://URI.Faster account load (N+1 removal)
On account change,
FillConversionSymbolsissued oneProtoOASymbolsForConversionReqper symbol (hundreds of sequential round-trips). It now requests each distinct quote asset once, bringing account load from minutes to seconds.How to test
,(e.g.de-DE), or temporarily setCultureInfo.CurrentCulture = new CultureInfo("de-DE")at startup. Authorize an account and select a symbol. Before: the chart area is blank (DevTools/CefSharp console showsUncaught SyntaxError: Unexpected token ','). After: candles render.dotnet buildthe sample and confirmChart.js\hammer.jsandChart.js\chartjs-plugin-zoom.min.jsare present in the outputChart.jsfolder.🤖 Generated with Claude Code