Fix support for test-suite/squidconf directive parameter files#2458
Closed
rousskov wants to merge 3 commits into
Closed
Fix support for test-suite/squidconf directive parameter files#2458rousskov wants to merge 3 commits into
rousskov wants to merge 3 commits into
Conversation
Those files were never found. 2022 commit d37a374 probably missed this bug because the corresponding `squid -k parse` failures (quoted below) do not result in non-zero exit status code. That failure handling problem deserves a dedicated fix. ERROR: Can not open file empty.conf for reading configuration context: ./squidconf/regressions-3.4.0.1.conf(27) ---- Cherry-picked OT commit 04abbe9 and commit 39b270e changes from SQUID-1064-make-configuration-includes-quoted-values-a-preprocessor-instruction-bag0 (a.k.a. commit 70014ef).
AFAICT, `realpath` is available on Linux, FreeBSD, and MacOS, but may not be available (by default) on Windows, [AIX](https://www.ibm.com/support/pages/resolving-ibm-content-navigator-310-configuration-error-aix-realpath-not-found-issue), and in other "exotic" environments. Squid did not use that shell command before this PR. Our test-squid-conf.sh script normally gets `$sbindir` parameter from Makefile, where it is provided by Automake. It my tests, it is always absolute, so this `realpath` step is not really needed. However, AFAICT, it is possible for `$sbindir` to be derived from a relative `$prefix` directory (or equivalent), necessitating `realpath` conversion in those arguably unusual cases. We can add a portable `cd && pwd`-based `realpath` replacement but let's keep it simple until the (currently questionable) need for handling relative `$sbindir` values is proven.
rousskov
added
M-cleared-for-merge
yadij
approved these changes
Jul 11, 2026
yadij
added
the
backport-to-v7
kinkie
approved these changes
Jul 11, 2026
squid-anubis
added
the
M-failed-other
rousskov
added
S-waiting-for-QA
squid-anubis
added
the
M-failed-other
rousskov
added
the
S-waiting-for-QA
squid-anubis
removed
the
M-failed-other
rousskov
removed
the
S-waiting-for-QA
squid-anubis
pushed a commit
that referenced
this pull request
Jul 12, 2026
Those files were never found. 2022 commit d37a374 probably missed this bug because the corresponding `squid -k parse` failures (quoted below) do not result in non-zero exit status code. That failure handling problem deserves a dedicated fix. ERROR: Can not open file empty.conf for reading configuration context: ./squidconf/regressions-3.4.0.1.conf(27)
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
squidadm
removed
the
backport-to-v7
Collaborator
|
queued for backport to v7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those files were never found. 2022 commit d37a374 probably missed this
bug because the corresponding
squid -k parsefailures (quoted below)do not result in non-zero exit status code. That failure handling
problem deserves a dedicated fix.