Add strict no-clobber restore#30
Merged
Merged
Conversation
frahlg
marked this pull request as ready for review
July 21, 2026 13:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ftw restore <backup> <absent-target>with versioned JSON outputSafety contract
Restore copies only
active.wlog, the selected manifest, and its active immutable rollups. It ignores orphan and older derived files. A deterministic CRC32 covers sorted relative paths, file lengths, and exact bytes.An existing target, including an empty directory, remains unchanged. Linux and Apple builds use
rustix::fs::renameat_withwithRenameFlags::NOREPLACE; unsupported targets fail closed.If the final parent sync or post-check fails, FTWDB verifies the published directory identity and rolls its own directory back while its shared store lock stays live. If rollback also fails,
SnapshotPublicationreports that state instead of hiding a visible target.CRC32 checks byte equality, not authenticity. Restore does not repair or salvage corrupt input; salvage stays in the next PR.
Validation
cargo fmt --all -- --checkcargo clippy --all-targets --all-features --locked --offline -- -D warningscargo test --all-targets --all-features --locked --offlinecargo test --doc --locked --offlinegit diff --check9ff1a95bENOSPC, checked 770,000-point/77-commit prefix