Skip to content

Chore: update example deps for ios#220

Merged
SbsCruz merged 13 commits into
integration-ios-android-example-updatefrom
chore/update-example-deps
Jul 22, 2026
Merged

Chore: update example deps for ios#220
SbsCruz merged 13 commits into
integration-ios-android-example-updatefrom
chore/update-example-deps

Conversation

@SbsCruz

@SbsCruz SbsCruz commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

This PR updates the dependencies in the example app to resolve compatibility issues with current React Native versions and cleans up environment configurations to fix build errors on ios.

Changes:

  • Updated dependencies in example/package.json.
  • Regenerated yarn.lock for consistency.
  • Updated App to use new RN components

@SbsCruz
SbsCruz marked this pull request as draft June 17, 2026 15:10
@SbsCruz
SbsCruz force-pushed the chore/update-example-deps branch from f4abe93 to 5f8984e Compare June 22, 2026 20:54
Comment thread example/index.js Outdated
const updateSpot = useCallback((): void => {
const indexes = typeof index === "number" ? [index] : index;

// eslint-disable-next-line sonarjs/argument-type

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SbsCruz ❓ 🔧 Why do we need to disable sonarjs? Can we try to resolve the issues instead of ignoring them?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are currently working on solving this, thanks!

Comment thread package/package.json
@mateopozor02
mateopozor02 changed the base branch from main to integration-ios-android-example-update July 3, 2026 15:39
@mateopozor02
mateopozor02 marked this pull request as ready for review July 7, 2026 20:25
Comment thread example/ios/SpotlightExample.xcodeproj/project.pbxproj
Comment thread example/ios/SpotlightExample.xcodeproj/project.pbxproj

@suany0805 suany0805 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job team!! i just left a couple of questions mainly to provide context

@SbsCruz
SbsCruz merged commit a86bfff into integration-ios-android-example-update Jul 22, 2026
5 checks passed
@SbsCruz
SbsCruz deleted the chore/update-example-deps branch July 22, 2026 18:48
SbsCruz added a commit that referenced this pull request Jul 22, 2026
* chore: update dependencies and configure environment for example app

* refactor: update example app to work with latest versions

* chore: fix eslint and vitest configurations with required ci script updates

* chore: suppress false positive sonarjs errors in components and tests

* chore: update react-test-renderer to 19.2.3

* chore: align React family package versions to 19.2.7

* chore: refresh Gemfile.lock for Ruby 3.2

* chore: disable sonarjs/argument-type rule globally

* refactor: register named Root component in example app

* chore: update podfile with new react versions

* fix: pin React family back to 19.2.3 to match react-native's bundled renderer

* refactor: modify function signatures and enable sonarjs checks

* chore: enable vitest flags at config level

---------

Co-authored-by: Mateo Pozo <mateopozoruiz02@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants