Skip to content

ALB Ingress Controller - Refactor unit and controller tests#1156

Closed
meneksece wants to merge 6 commits into
feat/kp/add-alb-ingress-controllerfrom
feat/mc/STACKITLB-2011-fix-unit-int-tests
Closed

ALB Ingress Controller - Refactor unit and controller tests#1156
meneksece wants to merge 6 commits into
feat/kp/add-alb-ingress-controllerfrom
feat/mc/STACKITLB-2011-fix-unit-int-tests

Conversation

@meneksece

@meneksece meneksece commented May 27, 2026 •
edited
Loading

Copy link
Copy Markdown

How to categorize this PR?

What this PR does / why we need it:

Refactors unit and gingko tests according to new changes.
Fixes some bugs mentioned below.

Which issue(s) this PR fixes:

Missing tls configuration for alb target pool when target pool tls is enabled via annotation on ingress.
Enables sorting ingresses via annotation priority and creation timestamp.
Makes sure the ALB option ephemeralAddress defaults to false when "alb.stackit.cloud/internal-alb" is defined as annotation on ingressClass.

Special notes for your reviewer:

Breaking changes:

@ske-prow

ske-prow Bot commented May 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xoxys for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 27, 2026
@meneksece meneksece changed the title ALB Ingress Controller - Refactor unit and gingko tests ALB Ingress Controller - Refactor unit and controller tests May 29, 2026
@ske-prow ske-prow Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 3, 2026
Menekse Ceylan added 5 commits June 5, 2026 14:26
fix tls bridging missing tlspool config and add tests and fix typo in…
e668e5f 
… tls annotations
updated annotation lookup when sorting ingresses for ingressClass
5570e63 
Utilized getSortedIngressesForIngressClass for getAlbSpecForIngressClass

# Conflicts:
#	pkg/alb/ingress/alb_spec.go
updated tests
db98c01
introduced sequenceIndex to not lose the order of rules when creating…
4a9bac7 
… alb specs via getAlbSpecForResources at last step
deleted unused comment
658962c 
fixed unit tests and added more for ingress controller
@meneksece meneksece force-pushed the feat/mc/STACKITLB-2011-fix-unit-int-tests branch from 78449df to 658962c Compare June 5, 2026 12:52
@ske-prow ske-prow Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 5, 2026
@ske-prow

ske-prow Bot commented Jun 5, 2026

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

internal alb annotation is fixed
3237fe8 
unit tests for alb spec are added
ensured that ephemeral address option defaults to false when internal-alb annotation is defined.
@ske-prow

ske-prow Bot commented Jun 8, 2026

Copy link
Copy Markdown

@meneksece: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-stackit-verify 3237fe8 link true /test pull-cloud-provider-stackit-verify

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see the gardener testing guideline for how to avoid and hunt flakes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ske-prow ske-prow Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 8, 2026
@fischerman

fischerman commented Jun 8, 2026

Copy link
Copy Markdown
Member

Cherry picked all commits to feat/kp/add-alb-ingress-controller

@fischerman fischerman closed this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@meneksece @fischerman