ROX-35254: rename BYODB job to match prefetch convention

[guzalv]

Description

The gke-byodb-test GHA workflow (added in b8fed2a) set CI_JOB_NAME=gke-byodb-test, which did not match any image prefetcher case in scripts/ci/lib.sh. The Splunk TA image (quay.io/rhacs-eng/qa:splunk-ta-test-latest) was not prefetched on GKE nodes, and IMAGE_PULL_POLICY_FOR_QUAY_IO was not set. This caused IntegrationsSplunkViolationsTest to fail during setupSpec() with deployment timeouts and SSL handshake errors.

The Prow equivalent job was named gke-external-pg-17-qa-e2e-tests, which matched the existing *qa-e2e-tests pattern in the prefetch dispatch. The GHA migration broke this by not following the naming convention.

Fix: rename the GHA job id and CI_JOB_NAME from gke-byodb-test to gke-byodb-qa-e2e-tests so it matches *qa-e2e-tests and gets image prefetching + quay pull policy automatically. This is a 2-line change in the workflow file; no changes needed to scripts/ci/lib.sh or the dispatch workflow.

User-facing documentation

• CHANGELOG.md is updated OR update is not needed
• documentation PR is created and is linked above OR is not needed

Testing and quality

• the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
• CI results are inspected

Automated testing

• added unit tests
• added e2e tests
• added regression tests
• added compatibility tests
• modified existing tests

The fix will be validated by the next gke-byodb-qa-e2e-tests run on master after merge. The existing IntegrationsSplunkViolationsTest is itself the regression test.

How I validated my change

Verified via bash case pattern matching that gke-byodb-qa-e2e-tests matches the existing *qa-e2e-tests pattern in the image prefetcher dispatch, which triggers the qa-e2e prefetch set (includes the Splunk TA image) and sets IMAGE_PULL_POLICY_FOR_QUAY_IO=Never on GKE.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 01e47f24-e14d-46e7-8797-7aadd3921044

📥 Commits

Reviewing files that changed from the base of the PR and between d666cbf and dc64ed5.

📒 Files selected for processing (2)

• .github/workflows/e2e-byodb-tests.yaml
• .github/workflows/e2e-dispatch.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• .github/workflows/e2e-byodb-tests.yaml

---

📝 Walkthrough

Summary by CodeRabbit

• Chores
  • Updated CI workflow and dispatch naming for the ByODB E2E test job (singular → plural).
  • Renamed the primary GKE job to the new QA E2E job identifier and updated the matching environment variable.
  • Adjusted restart-allow logcheck patterns to align with the new QA E2E job name.
  • No test behavior or runtime settings were changed.

Walkthrough

The BYODB end-to-end job is renamed across workflow, dispatch, and logcheck configuration from e2e-byodb-test/gke-byodb-test to e2e-byodb-tests/gke-byodb-qa-e2e-tests.

Changes

CI job rename

Layer / File(s)	Summary
Rename BYODB job in e2e-byodb-tests workflow .github/workflows/e2e-byodb-tests.yaml	Workflow display name changed to e2e-byodb-tests; job id renamed to gke-byodb-qa-e2e-tests and CI_JOB_NAME updated to match.
Update dispatch gating for renamed job .github/workflows/e2e-dispatch.yaml	should-dispatch jobs map key and the E2E job id renamed to e2e-byodb-tests; should-run expression and concurrency.group updated accordingly.
Update logcheck restart-ok patterns scripts/ci/logcheck/restart-ok-patterns.json	Job regex for indexer and matcher restart-allow entries updated from gke-byodb-test to gke-byodb-qa-e2e-tests.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly states the main change: renaming the BYODB job to match the prefetch convention.
Description check	✅ Passed	The PR description follows the template and covers the change, docs, testing, and validation with an explanation for skipped tests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch gualvare/ROX-35254-rename-byodb-job

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/e2e-byodb-test.yaml:
- Around line 30-38: The job rename in the workflow means the restart-log
allowlist no longer matches the active CI job. Update the `job` regex in
`scripts/ci/logcheck/restart-ok-patterns.json` so it references
`gke-byodb-qa-e2e-tests` instead of `gke-byodb-test`, and verify any other
old-name references used by `check-restart-logs.sh` and the `CI_JOB_NAME`-based
matching are kept in sync.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 782b2859-3f99-44b4-a197-31612734a189

📥 Commits

Reviewing files that changed from the base of the PR and between 6f66709 and 6cbdd52.

📒 Files selected for processing (1)

• .github/workflows/e2e-byodb-test.yaml

[github-actions]

🚀 Build Images Ready

Images are ready for commit 647a6d2. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.12.x-438-g647a6d2c14

[guzalv]

Updated — also renamed gke-byodb-test to gke-byodb-qa-e2e-tests in scripts/ci/logcheck/restart-ok-patterns.json (Scanner V4 restart allowlist). No other references to the old name remain in the repo.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.33%. Comparing base (b9a23ba) to head (647a6d2).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #21644      +/-   ##
==========================================
- Coverage   50.38%   50.33%   -0.05%     
==========================================
  Files        2844     2846       +2     
  Lines      218284   218344      +60     
==========================================
- Hits       109975   109911      -64     
- Misses     100331   100428      +97     
- Partials     7978     8005      +27     

Flag	Coverage Δ
go-unit-tests	50.33% <ø> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[msugakov]

Looks good. Thank you. Let's hope CI will be happy too.

[guzalv]

/fixxx