Skip to content

chore: add missing precision keywords#12675

Merged
kgryte merged 2 commits into
developfrom
philipp/fix-commit-review-2026-06-07
Jun 8, 2026
Merged

chore: add missing precision keywords#12675
kgryte merged 2 commits into
developfrom
philipp/fix-commit-review-2026-06-07

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

Follow-up fixes for commits merged to develop between 2026-06-06 14:40 PDT (f2640a213) and 2026-06-07 04:02 PDT (86dc341d3).

Two new complex-precision BLAS extension packages landed without the precision keyword that every sibling carries:

blas/ext/base

  • caxpby/package.json — Fix db04ac04 (blas/ext/base/caxpby/package.json): "single" was missing from the keywords array, inconsistent with sibling single-precision packages saxpby and caxpy; appended "single" after "float32".
  • zaxpby/package.json — Fix 2aa1270d (blas/ext/base/zaxpby/package.json): "double" was missing from the keywords array, inconsistent with sibling double-precision packages daxpby and zaxpy; appended "double" after "float64".

Related Issues

None.

Questions

None.

Other

Validation

Reviewed all 33 commits merged to develop in the window for typos, bugs, and style-guide violations. The audit was performed by four independent reviewer agents (two style, two bug) on top of a shared change summary.

  • Checked: stdlib code style compliance against sibling reference packages; JSDoc/REPL/TypeScript declaration consistency; obvious bugs (off-by-one, swapped operands, copy-paste errors, complex-number real/imag handling); security and incorrect-logic concerns in the introduced C and JS kernels.
  • Deliberately excluded: subjective polish, anything requiring interpretation, "could be improved" suggestions, anything that would require touching code outside the diff window to validate, drift in auto-generated namespace ToC / REPL data.csv / data.json files, and intentional patterns like the mass zerosempty benchmark setup change.

False positives that were considered and dropped:

  • array/falses/lib/main.js JSDoc @param default — actual file already reads [dtype="bool"]; agent misread the source.
  • dcunone/src/main.c missing const on offset locals — the const vs no-const pattern is mixed across blas/ext/base C sources (81 vs 30 occurrences), so this is not an unambiguous style violation.
  • swxsa/src/main.c using literal 5 instead of static const CBLAS_INT M = 5 — sibling sapx (closest single-precision in-place unrolled-loop kernel) uses the literal as well, so the family pattern is not uniform.

Checklist

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

Drafted by Claude Code as a follow-up audit of the last 24 hours of commits to develop. Independent style and bug reviewer agents produced a candidate finding set; each surviving finding was manually re-verified against the relevant sibling reference packages before being applied. PR left in draft for human maintainer audit.


@stdlib-js/reviewers


Generated by Claude Code

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Jun 7, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/caxpby $\color{green}494/494$
$\color{green}+100.00\%$
$\color{green}32/32$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}494/494$
$\color{green}+100.00\%$
blas/ext/base/zaxpby $\color{green}494/494$
$\color{green}+100.00\%$
$\color{green}32/32$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}494/494$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter marked this pull request as ready for review June 8, 2026 20:08
@Planeshifter Planeshifter requested review from a team and kgryte June 8, 2026 20:08
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 8, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jun 8, 2026
@kgryte kgryte changed the title chore: add missing precision keywords in new blas/ext/base packages chore: add missing precision keywords Jun 8, 2026
@kgryte kgryte merged commit 40d24b1 into develop Jun 8, 2026
54 checks passed
@kgryte kgryte deleted the philipp/fix-commit-review-2026-06-07 branch June 8, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants