Skip to content

test: migrate math/base/special/cscd to ULP-based testing #13664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Planeshifter wants to merge 1 commit into
base: develop
Choose a base branch
from
+14 −40
Draft

test: migrate math/base/special/cscd to ULP-based testing #13664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 7 additions & 20 deletions lib/node_modules/@stdlib/math/base/special/cscd/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,9 @@

var tape = require( 'tape' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var EPS = require( '@stdlib/constants/float64/eps' );
var PINF = require( '@stdlib/constants/float64/pinf' );
var NINF = require( '@stdlib/constants/float64/ninf' );
var abs = require( '@stdlib/math/base/special/abs' );
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
var cscd = require( './../lib' );


Expand Down Expand Up @@ -83,12 +82,12 @@ tape( 'the function returns `+0` if provided `+infinity`', function test( t ) {

tape( 'the function computes the cosecant in degrees (negative values)', function test( t ) {
var expected;
var delta;
var tol;
var ULP;
var x;
var y;
var i;

ULP = 2;

@kgryte kgryte Jul 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this variable. Just pass 2 directly to the isAlmostSameValue function. Applies here and for the other updated tests.

x = negative.x;
expected = negative.expected;

Expand All @@ -98,25 +97,19 @@ tape( 'the function computes the cosecant in degrees (negative values)', functio
t.strictEqual( y, NINF, 'x: '+x[i]+'. E: '+expected[i] );
continue;
}
if ( y === expected[ i ] ) {
t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] );
} else {
delta = abs( y - expected[i] );
tol = 1.4 * EPS * abs( expected[i] );
t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' );
}
t.strictEqual( isAlmostSameValue( y, expected[ i ], ULP ), true, 'returns expected value' );
}
t.end();
});

tape( 'the function computes the cosecant in degrees (positive values)', function test( t ) {
var expected;
var delta;
var tol;
var ULP;
var x;
var y;
var i;

ULP = 2;
x = positive.x;
expected = positive.expected;

Expand All @@ -126,13 +119,7 @@ tape( 'the function computes the cosecant in degrees (positive values)', functio
t.strictEqual( y, PINF, 'x: '+x[i]+'. E: '+expected[i] );
continue;
}
if ( y === expected[ i ] ) {
t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] );
} else {
delta = abs( y - expected[i] );
tol = 1.4 * EPS * abs( expected[i] );
t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' );
}
t.strictEqual( isAlmostSameValue( y, expected[ i ], ULP ), true, 'returns expected value' );
}
t.end();
});
27 changes: 7 additions & 20 deletions lib/node_modules/@stdlib/math/base/special/cscd/test/test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,9 @@
var resolve = require( 'path' ).resolve;
var tape = require( 'tape' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var EPS = require( '@stdlib/constants/float64/eps' );
var PINF = require( '@stdlib/constants/float64/pinf' );
var NINF = require( '@stdlib/constants/float64/ninf' );
var abs = require( '@stdlib/math/base/special/abs' );
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
var tryRequire = require( '@stdlib/utils/try-require' );


Expand Down Expand Up @@ -92,12 +91,12 @@ tape( 'the function returns `+0` if provided `+infinity`', opts, function test(

tape( 'the function computes the cosecant in degrees (negative values)', opts, function test( t ) {
var expected;
var delta;
var tol;
var ULP;
var x;
var y;
var i;

ULP = 2;
x = negative.x;
expected = negative.expected;

Expand All @@ -107,25 +106,19 @@ tape( 'the function computes the cosecant in degrees (negative values)', opts, f
t.strictEqual( y, NINF, 'x: '+x[i]+'. E: '+expected[i] );
continue;
}
if ( y === expected[ i ] ) {
t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] );
} else {
delta = abs( y - expected[i] );
tol = 1.4 * EPS * abs( expected[i] );
t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' );
}
t.strictEqual( isAlmostSameValue( y, expected[ i ], ULP ), true, 'returns expected value' );
}
t.end();
});

tape( 'the function computes the cosecant in degrees (positive values)', opts, function test( t ) {
var expected;
var delta;
var tol;
var ULP;
var x;
var y;
var i;

ULP = 2;
x = positive.x;
expected = positive.expected;

Expand All @@ -135,13 +128,7 @@ tape( 'the function computes the cosecant in degrees (positive values)', opts, f
t.strictEqual( y, PINF, 'x: '+x[i]+'. E: '+expected[i] );
continue;
}
if ( y === expected[ i ] ) {
t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] );
} else {
delta = abs( y - expected[i] );
tol = 1.4 * EPS * abs( expected[i] );
t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' );
}
t.strictEqual( isAlmostSameValue( y, expected[ i ], ULP ), true, 'returns expected value' );
}
t.end();
});
Loading