fix: Race condition on init & add method for overriding config options#172
Open
Pecacheu wants to merge 4 commits into
Open
fix: Race condition on init & add method for overriding config options#172Pecacheu wants to merge 4 commits into
Pecacheu wants to merge 4 commits into
Conversation
…s before configured() is set Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
Dadadah
approved these changes
Jul 23, 2026
Dadadah
requested changes
Jul 23, 2026
Dadadah
left a comment
Dadadah
left a comment
Member
There was a problem hiding this comment.
i accidentally made the last review an approve whoops lol
Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
Dadadah
requested changes
Jul 24, 2026
Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix race condition upon config fetch without breaking any compatibility, while also providing a much more reliable means of overriding individual config options before the
configured()flag is set, solving two related race conditions in one go.