fix: GameProfilingSystem crashes on Vulkan (FastTextRenderer null command buffer)

[sasvdw]

PR Details

Fixes a native crash (0xC0000005) on the Vulkan backend: enabling the on-screen game profiler (GameProfilingSystem, toggled with F7) crashes within a couple of frames inside FastTextRenderer.End.

Fatal error. 0xC0000005
   at Vortice.Vulkan.Vulkan.vkCmdBindVertexBuffers(...)   // on master; 4.3.x faults one call earlier at vkCmdBindPipeline
   at Stride.Graphics.CommandList.SetVertexBuffer(...)
   at Stride.Graphics.FastTextRenderer.End(...)
   at Stride.Profiling.GameProfilingSystem.Draw(...)

Root cause

GameProfilingSystem.Draw rendered FastTextRenderer through RenderContext.GetShared(Services).GetThreadContext(). On Vulkan that returns a thread-local pipeline-worker command list, which is Close()d during the compositor's parallel scene rendering (RenderSystem.Draw) and never re-begun afterwards — so its native VkCommandBuffer is null, and recording draw commands into it in FastTextRenderer.End dereferences a null handle → access violation.

It only worked on Direct3D11 because D3D11 records serially (IsDeferred == false) and its thread contexts alias the single main command list via GraphicsDevice.InternalMainCommandList — which Vulkan intentionally does not set, because it does genuine parallel command-buffer recording. So the profiler was the one GameSystem.Draw-level caller reaching into a pipeline-internal context that isn't valid outside the render pipeline.

Fix

Render through Game.GraphicsContext — the main, per-frame command list that GameBase.BeginDraw resets and begins every frame — exactly as DebugTextSystem (the other FastTextRenderer consumer) already does. Behaviour-preserving on Direct3D11 (that was already the main command list); fixes the crash on Vulkan. Single method changed; no FastTextRenderer change needed.

Validation

Built the engine at a single consistent version and A/B-tested a minimal real game: without the change it crashes 3/3, with it runs cleanly and the profiler overlay renders. Minimal self-contained reproduction (clone + dotnet run on a Vulkan GPU): https://github.com/sasvdw/stride-1020-vulkan-profiler-repro

Note / follow-up

This is the targeted caller fix. The deeper issue — GetThreadContext() silently handing a GameSystem.Draw an invalid (closed) command list on Vulkan, so any future out-of-pipeline drawing system is a latent crash — is a framework concern (DebugTextSystem even carries a // TODO GRAPHICS REFACTOR where to get command list from?). I've kept this PR minimal and low-risk and will raise that separately as a proposal.

Related Issue

Closes #1020. Related: #630 ([Vulkan] WriteDiscard support — same FastTextRenderer-on-Vulkan area).

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My change requires a change to the documentation.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have built and run the editor to try this change out.