Skip to content

chore: improve by fixing some issues with broken URLs#508

Merged
thisismana merged 1 commit into
mainfrom
improve-url-handling
Jun 29, 2026
Merged

chore: improve by fixing some issues with broken URLs#508
thisismana merged 1 commit into
mainfrom
improve-url-handling

Conversation

@thisismana

Copy link
Copy Markdown
Member
  • sometimes clients requests images that look like a image sourceset (eg. ending with .jpg%20180w): this pr fixes this to deliver the correct image
  • also fix a logging issue where aws exceptions are using upper case keys

Comment thread source/image-handler/src/image-request.ts Fixed
@thisismana thisismana force-pushed the improve-url-handling branch from 783e119 to 964e0eb Compare June 29, 2026 11:52
- sometimes clients requests images that look like a image sourceset (eg. ending with `.jpg%20180w`): this pr fixes this to deliver the correct image
- also fix a logging issue where aws exceptions are using upper case keys
@thisismana thisismana force-pushed the improve-url-handling branch from 964e0eb to f7546d1 Compare June 29, 2026 12:39

@bastianpahlke bastianpahlke left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisismana thisismana enabled auto-merge (squash) June 29, 2026 12:51
@thisismana thisismana merged commit d166673 into main Jun 29, 2026
10 checks passed
@thisismana thisismana deleted the improve-url-handling branch June 29, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants