fix(functions): pass deno config as import map#5369
Closed
Subharup-31 wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for your contribution! 🙏 This bug was fixed during the TypeScript port of the command so I'm closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Pass the resolved import map to edge-runtime whenever one is configured, including
deno.jsonanddeno.jsoncfiles that live beside the function entrypoint.This fixes the regression described in #5069 where bare imports from
deno.jsonwere no longer resolved duringsupabase functions deploybecause the CLI skipped--import-mapand relied on edge-runtime auto-discovery.Why
The CLI already resolves the correct import map path before bundling. Passing it explicitly keeps legacy
import_map.jsonbehavior and restoresdeno.json/deno.jsoncimport resolution for both native and Docker bundling.Verification
GOCACHE=... GOMODCACHE=... go test ./functionfromapps/cli-go/pkgpassedGOCACHE=... GOMODCACHE=... go test ./internal/functions/deployfromapps/cli-gowas attempted, but the runner volume ran out of temp build space while compiling dependencies before package tests could run