test(cli): guard config schema against inbucket name leakage#5664
Open
jgoux wants to merge 1 commit into
Open
Conversation
Assert the generated schema contains no `inbucket` substring case-insensitively (descriptions included), so the deprecated implementation name cannot creep back into the published schema. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@89ffc8c5612b9d62db53184a079ff292470cccdePreview package for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5333 (the
inbucket→local_smtpconfig rename).Strengthens the config-schema unit test so the deprecated implementation name cannot creep back into the published schema: the assertion now checks the generated schema case-insensitively (
schemaString.toLowerCase()), covering descriptions as well as keys — not just the lowercaseinbucketsubstring.#5333 already removed the last user-facing
inbucketreferences (the section key, plus the schema descriptions/link which now point at the actual local tool, Mailpit). This test makes that invariant durable.🤖 Generated with Claude Code