nix: Avoid unnecessary nixpkgs#2216
Open
mmlb wants to merge 2 commits into
Open
Conversation
Sort the inputs themselves and have .url first and then everything else follows in order. Also added new lines to break up the big block of text which should make it easier to read and catch the issue thats getting fixed in the next commit next time it happens.
Otherwise we bring in another nixpkgs revision that gets copied into the store, unnecessarily.
PostgreSQL Extension Dependency Analysis: PR #2216
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2216
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
DevEx (minor)
What is the current behavior?
I noticed we had an extra nixpkgs in flake.lock, was easy to miss because its actually something that nix-eval-jobs should have done on its own (by propagating the nixpkgs input to its treefmt-nix). This does have a slight/tiny effect on build times since we waste time fetching a nixpkgs tree and copying into /nix/store only for it to never be used.
What is the new behavior?
No time wasted fetching unnecessary nixpkgs tree, no time wasted copying into /nix/store.