Make Windows CI fail when command fails to launch#307
Open
snprajwal wants to merge 1 commit into
Open
Conversation
Invoke-Program used `exit $LastExitCode`, but when a native command fails to launch (e.g. a broken toolchain) no exit code is set, leaving `$LASTEXITCODE` as $null. `exit $null` exits 0, so the container reports success and the step is green despite the failure (like this occurence[1] in swiftlang/swift-package-manager). Reset `$LASTEXITCODE` before each call and fall back to $? when no exit code is produced, so launch failures now fail properly. [1]: https://github.com/swiftlang/swift-package-manager/actions/runs/29766644951/job/88434456907?pr=10308
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invoke-Program used
exit $LastExitCode, but when a native command fails to launch (e.g. a broken toolchain) no exit code is set, leaving $LASTEXITCODE as $null.exit $nullexits 0, so the container reports success and the step is green despite the failure (like this occurence in swiftlang/swift-package-manager).Reset
$LASTEXITCODEbefore each call and fall back to $? when no exit code is produced, so launch failures now fail properly.