Fix inefficient recursion in Value.All#44
Open
Lykathia wants to merge 1 commit into
Open
Conversation
Lykathia
force-pushed
the
lykathia/all-recursion
branch
from
July 18, 2026 02:04
712bc95 to
093f83f
Compare
Included a benchmark, updated to go 1.26 to get b.Loop from 1.24.
Before:
goos: linux
goarch: amd64
pkg: github.com/tailscale/hujson
cpu: AMD Ryzen AI 9 HX 370 w/ Radeon 890M
BenchmarkAll-24 1549588 724.1 ns/op 1200 B/op 49 allocs/op
After:
goos: linux
goarch: amd64
pkg: github.com/tailscale/hujson
cpu: AMD Ryzen AI 9 HX 370 w/ Radeon 890M
BenchmarkAll-24 2830897 405.5 ns/op 680 B/op 31 allocs/op
Signed-off-by: Evan Lowry <evan@tailscale.com>
Lykathia
force-pushed
the
lykathia/all-recursion
branch
from
July 18, 2026 02:05
093f83f to
05bb36c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included a benchmark, updated to go 1.26 to get b.Loop from 1.24.
Before:
After: