Skip to content

chore(cleanup): delete dead eval-persona facade + orphaned topology module#367

Merged
drewstone merged 1 commit into
mainfrom
chore/delete-dead-runtime
Jun 23, 2026
Merged

chore(cleanup): delete dead eval-persona facade + orphaned topology module#367
drewstone merged 1 commit into
mainfrom
chore/delete-dead-runtime

Conversation

@drewstone

Copy link
Copy Markdown
Contributor

Removes two confirmed-dead runtime surfaces and bumps to 0.76.0.

Deleted

  • evalPersona / EvalPersonaOptions (src/conversation/eval-persona.ts + test) — the one-call user-sim facade, superseded by the brain-from-profile overhaul (refactor: usability overhaul — brain-from-profile, surface shrink, docs that can't lie, supervise() one-call #347). Zero external consumers (grep'd ~/code excluding node_modules + every agent-runtime checkout). The in-repo examples/product-eval is migrated to the kept lower-level runPersonaConversation seam, so the example stays live.
  • src/topology/createTopologyView / renderTopologyTree / createReplayRecorder / renderReplayHtml. @experimental, no package.json export, no consumer. bench/src/atom-humaneval.mts drops only its optional HTML replay side-output; the driver-vs-blind verdict is untouched.

Kept (re-verify found a real consumer)

  • runPersonaConversation / runPersonaDispatch / PersonaDriver (src/conversation/run-persona.ts) — tax-agent (tests/eval/self-improve.ts, dep ^0.75.1) imports runPersonaDispatch + PersonaDriver from the published package. Per the re-verify-before-delete rule, the persona loop runner stays.

Verification (all green, clean worktree off origin/main)

  • pnpm run build — DTS emitted for all entries
  • pnpm run typecheck — 0 errors (incl. examples)
  • pnpm test — 112 files, 1102 passed / 1 skipped / 0 failed (the closed-loop lifecycle proof + full suite green)
  • pnpm run lint — 319 files, clean
  • pnpm run docs:checkdocs:api regenerated, docs/api diff committed, freshness gate OK (version pin 0.76.0 accurate, all citations + symbols resolve)

Net: 16 files, +38 / −1120.

…odule (0.76.0)

Remove two confirmed-dead surfaces:

- `evalPersona` / `EvalPersonaOptions` (src/conversation/eval-persona.ts) — the
  one-call user-sim facade superseded by the brain-from-profile overhaul. Zero
  external consumers; the in-repo product-eval example is migrated to the kept
  lower-level `runPersonaConversation` seam.
- `src/topology/` (createTopologyView / renderTopologyTree / createReplayRecorder /
  renderReplayHtml) — an @experimental live-tree/replay viz with no package export
  and no consumer. The atom-humaneval bench drops its optional HTML replay output.

KEPT: `runPersonaConversation` / `runPersonaDispatch` / `PersonaDriver`
(src/conversation/run-persona.ts) — a re-verify found tax-agent imports these from
the published package, so the persona loop runner stays.

Regenerate docs/api, bump the docs version pin, and refresh the architecture doc
to drop the deleted-module references.

@tangletools tangletools left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved PR — a56ba63c

Blanket team auto-approval is enabled for this reviewer service.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.

tangletools · auto-approval · reason: blanket_auto_approve · 2026-06-23T07:59:41Z

@drewstone drewstone merged commit e23316f into main Jun 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants