chore(cleanup): delete dead eval-persona facade + orphaned topology module#367
Merged
Conversation
…odule (0.76.0) Remove two confirmed-dead surfaces: - `evalPersona` / `EvalPersonaOptions` (src/conversation/eval-persona.ts) — the one-call user-sim facade superseded by the brain-from-profile overhaul. Zero external consumers; the in-repo product-eval example is migrated to the kept lower-level `runPersonaConversation` seam. - `src/topology/` (createTopologyView / renderTopologyTree / createReplayRecorder / renderReplayHtml) — an @experimental live-tree/replay viz with no package export and no consumer. The atom-humaneval bench drops its optional HTML replay output. KEPT: `runPersonaConversation` / `runPersonaDispatch` / `PersonaDriver` (src/conversation/run-persona.ts) — a re-verify found tax-agent imports these from the published package, so the persona loop runner stays. Regenerate docs/api, bump the docs version pin, and refresh the architecture doc to drop the deleted-module references.
tangletools
approved these changes
Jun 23, 2026
tangletools
left a comment
Contributor
There was a problem hiding this comment.
✅ Auto-approved PR — a56ba63c
Blanket team auto-approval is enabled for this reviewer service.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-06-23T07:59:41Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two confirmed-dead runtime surfaces and bumps to 0.76.0.
Deleted
evalPersona/EvalPersonaOptions(src/conversation/eval-persona.ts+ test) — the one-call user-sim facade, superseded by the brain-from-profile overhaul (refactor: usability overhaul — brain-from-profile, surface shrink, docs that can't lie, supervise() one-call #347). Zero external consumers (grep'd~/codeexcludingnode_modules+ every agent-runtime checkout). The in-repoexamples/product-evalis migrated to the kept lower-levelrunPersonaConversationseam, so the example stays live.src/topology/—createTopologyView/renderTopologyTree/createReplayRecorder/renderReplayHtml.@experimental, nopackage.jsonexport, no consumer.bench/src/atom-humaneval.mtsdrops only its optional HTML replay side-output; the driver-vs-blind verdict is untouched.Kept (re-verify found a real consumer)
runPersonaConversation/runPersonaDispatch/PersonaDriver(src/conversation/run-persona.ts) —tax-agent(tests/eval/self-improve.ts, dep^0.75.1) importsrunPersonaDispatch+PersonaDriverfrom the published package. Per the re-verify-before-delete rule, the persona loop runner stays.Verification (all green, clean worktree off
origin/main)pnpm run build— DTS emitted for all entriespnpm run typecheck— 0 errors (incl. examples)pnpm test— 112 files, 1102 passed / 1 skipped / 0 failed (the closed-loop lifecycle proof + full suite green)pnpm run lint— 319 files, cleanpnpm run docs:check—docs:apiregenerated,docs/apidiff committed, freshness gate OK (version pin 0.76.0 accurate, all citations + symbols resolve)Net: 16 files, +38 / −1120.