Skip to content

feat(validation): include error messages in ValidationFailed exception message #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendt merged 3 commits into from
Jul 15, 2026
Merged

feat(validation): include error messages in ValidationFailed exception message #2203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b86ec0
feat(validation): include error messages in ValidationFailed exceptio…
mgalexandre Jul 8, 2026
28b71b4
feat(validation): expose validation errors via ProvidesContext and a …
mgalexandre Jul 9, 2026
d01e9b1
chore(validation): inline string concatenation into sprintf call
mgalexandre Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions packages/validation/src/Exceptions/ValidationFailed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@
namespace Tempest\Validation\Exceptions;

use Exception;
use Tempest\Core\ProvidesContext;
use Tempest\Validation\FailingRule;
use Tempest\Validation\Internal\MessageRule;

final class ValidationFailed extends Exception
final class ValidationFailed extends Exception implements ProvidesContext
{
/**
* @template TKey of array-key
Expand All @@ -23,10 +24,23 @@ public function __construct(
private(set) array $errorMessages = [],
private(set) ?string $targetClass = null,
) {
parent::__construct(match (true) {
$message = match (true) {
is_null($subject) => 'Validation failed.',
default => sprintf('Validation failed for %s.', is_object($subject) ? $subject::class : $subject),
});
};

foreach ($errorMessages as $field => $messages) {
$message .= sprintf('%s- %s: %s', PHP_EOL, $field, implode('; ', $messages));
}

parent::__construct($message);
}

public function context(): iterable
{
return array_filter([
'errors' => $this->errorMessages,
]);
}

/**
Expand Down
37 changes: 37 additions & 0 deletions packages/validation/tests/ValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,43 @@ public function test_validation_failed_can_be_created_from_messages(): void
$this->assertSame('Email domain is not allowed', $this->validator->getErrorMessage($validationFailed->failingRules['email'][1]));
}

public function test_validation_failed_message_includes_error_messages(): void
{
$validationFailed = ValidationFailed::withMessages([
'credential' => 'Passkey not valid',
'email' => [
'Email is already taken',
'Email domain is not allowed',
],
]);

$this->assertSame(
implode(PHP_EOL, [
'Validation failed.',
'- credential: Passkey not valid',
'- email: Email is already taken; Email domain is not allowed',
]),
$validationFailed->getMessage(),
);
}

public function test_validation_failed_message_omits_error_messages_when_empty(): void
{
$validationFailed = new ValidationFailed(failingRules: []);

$this->assertSame('Validation failed.', $validationFailed->getMessage());
}

public function test_validation_failed_provides_error_messages_as_context(): void
{
$validationFailed = ValidationFailed::withMessages([
'email' => 'Email is already taken',
]);

$this->assertSame(['errors' => ['email' => ['Email is already taken']]], $validationFailed->context());
$this->assertSame([], new ValidationFailed(failingRules: [])->context());
}

public function test_closure_passes_with_null_response(): void
{
$validator = $this->validator;
Expand Down
Loading