fix(router)!: block all cross-site unsafe requests when using PreventCrossSiteRequestsMiddleware#2210
Merged
Merged
Conversation
…CrossSiteRequestsMiddleware`
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit 1a5eb1a |
brendt
approved these changes
Jul 15, 2026
PreventCrossSiteRequestsMiddlewarePreventCrossSiteRequestsMiddleware
brendt
approved these changes
Jul 15, 2026
Member
|
Thanks to @edorian for flagging this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I initially implemented this with the idea that Tempest defaults to using LAX cookies, so sessions are not carried during cross-site POST requests.
However, it's better to special-case the routes that need support for this instead of it being allowed by default, so this PR changes that.
Marking as breaking because technically it is, payment provider flows might be affected and related routes will need to get hand-rolled protection.