Skip to content

fix(view): lexer source mapping#2225

Merged
brendt merged 2 commits into
3.xfrom
fix-lexer-source-mapping
Jul 17, 2026
Merged

fix(view): lexer source mapping#2225
brendt merged 2 commits into
3.xfrom
fix-lexer-source-mapping

Conversation

@brendt

@brendt brendt commented Jul 17, 2026

Copy link
Copy Markdown
Member

I broke it, then I fixed it. Well technically Mark fixed it and I copied his solution :p

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

Benchmark Results

Comparison of fix-lexer-source-mapping against 3.x (44a5501bc811a654767c03346488c3fd6edd8158).

Open to see the benchmark results
Benchmark Set Mem. Peak Time Variability
QueryExecutionBench(benchExecuteInsert) - 4.364mb 0.00% 12.874μs +5.57% ±2.22% -15.76%

Generated by phpbench against commit 0426d88

@xHeaven

xHeaven commented Jul 17, 2026

Copy link
Copy Markdown
Member

I've added coverage for newline-with-indentation as well.

@xHeaven

xHeaven commented Jul 17, 2026

Copy link
Copy Markdown
Member

It's okay, Windows CI is at 30% after 16 minutes. A couple of hours and it'll finish. No pressure.

@brendt

brendt commented Jul 17, 2026

Copy link
Copy Markdown
Member Author

Don't you dare push a new commit

@brendt
brendt merged commit 925a280 into 3.x Jul 17, 2026
76 checks passed
@brendt
brendt deleted the fix-lexer-source-mapping branch July 17, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants