Skip to content

ASoC: SOF: Intel: Power down DSP if it is left enabled in pre_fw_run() #5763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ujfalusi wants to merge 2 commits into
base: topic/sof-dev
Choose a base branch
from
+37 −0
Open

ASoC: SOF: Intel: Power down DSP if it is left enabled in pre_fw_run() #5763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
945e36f
ASoC: SOF: Intel: hda: Power down DSP if it is left enabled in pre_fw…
ujfalusi May 4, 2026
71cdc60
ASoC: SOF: Intel: mtl: Power down DSP if it is left enabled in pre_fw…
ujfalusi May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions sound/soc/sof/intel/hda.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,20 @@ static inline void hda_dsp_sdw_process_mic_privacy(struct snd_sof_dev *sdev) { }
/* pre fw run operations */
int hda_dsp_pre_fw_run(struct snd_sof_dev *sdev)
{
struct sof_intel_hda_dev *hda = sdev->pdata->hw_pdata;
const struct sof_intel_dsp_desc *chip = hda->desc;
int ret;

/* Power down DSP if left enabled to ensure a clean boot state. */
if (hda_dsp_core_is_enabled(sdev, chip->host_managed_cores_mask)) {
dev_dbg(sdev->dev, "DSP core enabled, power down DSP first\n");

ret = chip->power_down_dsp(sdev);
if (ret < 0)
Comment on lines +428 to +433

@jsarha jsarha Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me that host_managed_cores_mask is BIT(0) for all cores I have worked on (tgl, mtl, lnl, ptl, nvl). So to me it looks like Copilots comment is not valid, for those but I can not tell if there is other cases the point is valid, so I do not dare to approve this yet.

dev_warn(sdev->dev,
"%s: failed to power down already-enabled DSP\n", __func__);
}

/* disable clock gating and power gating */
return hda_dsp_ctrl_clock_power_gating(sdev, false);
}
Expand Down
23 changes: 23 additions & 0 deletions sound/soc/sof/intel/mtl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,17 @@ int mtl_enable_interrupts(struct snd_sof_dev *sdev, bool enable)
}
EXPORT_SYMBOL_NS(mtl_enable_interrupts, "SND_SOC_SOF_INTEL_MTL");

static bool mtl_dsp_is_enabled(struct snd_sof_dev *sdev)
{
int val;

val = snd_sof_dsp_read(sdev, HDA_DSP_BAR, MTL_HFDSSCS);
if (val & MTL_HFDSSCS_CPA_MASK)
return true;

return false;
Comment on lines +239 to +247
}

/* pre fw run operations */
static int mtl_dsp_pre_fw_run(struct snd_sof_dev *sdev)
{
Expand All @@ -249,6 +260,18 @@ static int mtl_dsp_pre_fw_run(struct snd_sof_dev *sdev)
u32 dsppwrsts;
const struct sof_intel_dsp_desc *chip;

/* Power down the DSP if it is left enabled to ensure clean boot state */
if (mtl_dsp_is_enabled(sdev)) {
dev_dbg(sdev->dev, "powering down DSP first\n");

ret = mtl_power_down_dsp(sdev);
if (ret < 0) {
dev_warn(sdev->dev,
"%s: failed to power down already-enabled DSP\n", __func__);
/* Continue anyway to attempt recovery */
}
}

chip = get_chip_info(sdev->pdata);
if (chip->hw_ip_version > SOF_INTEL_ACE_2_0) {
dsppwrctl = PTL_HFPWRCTL2;
Expand Down
Loading