mux: validation fixes#10885
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens validation for the mux component configuration in both IPC4 and IPC3 paths to prevent out-of-bounds indexing and to fail fast on unsupported “mixing” configurations.
Changes:
- IPC4: add validation for host-supplied channel counts and source queue IDs; propagate validation failures via return codes.
- IPC3: make
mux_mix_check()failure return-EINVALinstead of only logging an error.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/audio/mux/mux_ipc4.c |
Adds IPC4 config/param validation and error propagation for invalid channel counts and queue IDs. |
src/audio/mux/mux_ipc3.c |
Ensures mux channel-mixing validation failures abort parameter setup with -EINVAL. |
abonislawski
force-pushed
the
fix/mux-ipc3-ipc4
branch
from
56b508b to
699b915
Compare
kv2019i
approved these changes
Jun 12, 2026
abonislawski
force-pushed
the
fix/mux-ipc3-ipc4
branch
from
699b915 to
de13e3d
Compare
Member
Author
|
Added one more IPC4 check for copilot & validated all possible formats in IPC4 tests |
abonislawski
force-pushed
the
fix/mux-ipc3-ipc4
branch
from
de13e3d to
c43acb0
Compare
lgirdwood
approved these changes
Jun 12, 2026
build_config() looped over host-supplied channels_count writing streams[].mask[] (size PLATFORM_MAX_CHANNELS), overflowing it. Reject counts above the max. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
tmleman
approved these changes
Jun 12, 2026
lyakh
requested changes
Jun 12, 2026
abonislawski
force-pushed
the
fix/mux-ipc3-ipc4
branch
from
c43acb0 to
0c6ba92
Compare
Member
Author
|
Cosmetic changes only |
lyakh
approved these changes
Jun 15, 2026
set_mux_params() indexed streams[] with the host-supplied bind queue ID without bounds, allowing an OOB write. Validate against MUX_MAX_STREAMS and propagate the error. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
abonislawski
force-pushed
the
fix/mux-ipc3-ipc4
branch
from
0c6ba92 to
f4960a2
Compare
mux_set_values() logged a mux_mix_check() failure but still returned success, applying an invalid routing matrix. Return -EINVAL, matching the IPC4 path. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
abonislawski
force-pushed
the
fix/mux-ipc3-ipc4
branch
from
f4960a2 to
baf26e7
Compare
Member
Author
|
Just rerun, no changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.